Attachment 174549 Details for Bug 24690 – Bug 24690: Make OPACPopupAuthorsSearch work with search terms containing parenthesis

[patch] Bug 24690: Make OPACPopupAuthorsSearch work with search terms containing parenthesis

Bug-24690-Make-OPACPopupAuthorsSearch-work-with-se.patch (text/plain), 2.32 KB, created by Marcel de Rooy on 2024-11-15 09:34:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2024-11-15 09:34:05 UTC

Size: 2.32 KB

patch

obsolete

>From b0072677c52aa94f16a543f9688a50701dd6629b Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 1 Jul 2024 12:28:56 +0000
>Subject: [PATCH] Bug 24690: Make OPACPopupAuthorsSearch work with search terms
> containing parenthesis
>Content-Type: text/plain; charset=utf-8
>
>This patch updates the OPACPopupAuthorsSearch feature so that it wraps
>search terms with quotes. This is the behavior we have in place for
>author searches outside the context of OPACPopupAuthorisSearch, e.g.
>'au:"Criterion Collection (Firm)"'
>
>To test, apply the patch and enable the OPACPopupAuthorsSearch system
>preference.
>
>- Search for a record in the OPAC which has author data containing
>  parentheses (it should not be a field linked to an authority record).
>- View the detail page for that record.
>- Click on one of the problematic author links.
>- This should trigger a modal window with a list of authors and
>  checkboxes for each.
>- With just the single checkbox checked, click "Search."
>- The search should return the correct results.
>- Test other author searches to confirm that they work too.
>
>Sponsored-by: Athens County Public Libraries
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>index e172ce258c..0866e7dd45 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>@@ -1966,7 +1966,7 @@
>                                 authid = $(this).data("authid");
>                                 search_string = "an:" + authid;
>                             } else {
>-                                search_string = terms[term]["keyword_search"] + encodeURIComponent( search_label );
>+                                search_string = terms[term]["keyword_search"] + '"' + encodeURIComponent( search_label ) + '"';
>                             }
>                             var termLink = $("<li>")
>                                 .append( $("<input>", { type: "checkbox", class: "select_term", value: search_string, id: terms[term]["label"] + index } ).prop("checked", preselected ) )
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 24690: 168315 | 168316 | 168334 | 174549