Attachment 174561 Details for Bug 37398 – Bug 37398: Add a unit test

[patch] Bug 37398: Add a unit test

Bug-37398-Add-a-unit-test.patch (text/plain), 2.32 KB, created by Marcel de Rooy on 2024-11-15 10:42:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2024-11-15 10:42:00 UTC

Size: 2.32 KB

patch

obsolete

>From 23c9a7b8eb1838dc946fc4d125e21c601010137b Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Thu, 12 Sep 2024 17:35:15 +0000
>Subject: [PATCH] Bug 37398: Add a unit test
>Content-Type: text/plain; charset=utf-8
>
>Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/db_dependent/Koha/UI/Form/Builder/Item.t | 29 +++++++++++++++++++++-
> 1 file changed, 28 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/UI/Form/Builder/Item.t b/t/db_dependent/Koha/UI/Form/Builder/Item.t
>index 92a7411797..068374e562 100755
>--- a/t/db_dependent/Koha/UI/Form/Builder/Item.t
>+++ b/t/db_dependent/Koha/UI/Form/Builder/Item.t
>@@ -16,7 +16,7 @@
> # along with Koha; if not, see <http://www.gnu.org/licenses>.
> 
> use Modern::Perl;
>-use Test::More tests => 9;
>+use Test::More tests => 10;
> use Test::MockModule;
> use Data::Dumper qw( Dumper );
> use utf8;
>@@ -239,6 +239,33 @@ subtest 'default_branches_empty' => sub {
>     is( $subfield->{marc_value}->{values}->[0], "", 'empty option for branches if default_branches_empty passed' );
> };
> 
>+subtest 'kohafields_to_add_datepicker' => sub {
>+    plan tests => 5;
>+
>+    my $biblio =
>+      $builder->build_sample_biblio( { value => { frameworkcode => '' } } );
>+    my $subfields =
>+      Koha::UI::Form::Builder::Item->new(
>+        { biblionumber => $biblio->biblionumber } )->edit_form;
>+
>+    my @itemfield_test_cases = (
>+        { kohafield => 'items.dateaccessioned', expected_type => 'date' },
>+        { kohafield => 'items.replacementpricedate', expected_type => 'date' },
>+        { kohafield => 'items.datelastborrowed', expected_type => 'date' },
>+        { kohafield => 'items.onloan', expected_type => 'date' },
>+        { kohafield => 'items.datelastseen', expected_type => 'datetime' },
>+    );
>+
>+    foreach my $itemfield_test_case (@itemfield_test_cases) {
>+        my ( $subfield ) = grep { $_->{kohafield} eq $itemfield_test_case->{kohafield} } @$subfields;
>+        if ( $subfield ) {
>+            is( $subfield->{datetype}, $itemfield_test_case->{expected_type}, "Correct datetype for $itemfield_test_case->{kohafield}" );
>+        } else {
>+            ok( 0, "Subfield for $itemfield_test_case->{kohafield} not found" );
>+        }
>+    }
>+};
>+
> subtest 'kohafields_to_ignore' => sub {
>     plan tests => 2;
> 
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 37398: 171416 | 171417 | 171419 | 171420 | 171421 | 171422 | 171423 | 171424 | 171881 | 171882 | 171919 | 171963 | 172187 | 172188 | 172189 | 172190 | 172191 | 172192 | 172193 | 172194 | 172195 | 172196 | 174558 | 174559 | 174560 | 174561 | 174562 | 174563 | 174564 | 174565 | 174566