Attachment 174568 Details for Bug 37946 – Bug 37946: (follow-up) Update menu style to hide

[patch] Bug 37946: (follow-up) Update menu style to hide

Bug-37946-follow-up-Update-menu-style-to-hide.patch (text/plain), 1.29 KB, created by Marcel de Rooy on 2024-11-15 11:02:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2024-11-15 11:02:37 UTC

Size: 1.29 KB

patch

obsolete

>From 8ec5a7ce7fcc0adb2aeae920533c2a56025e2a71 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 20 Sep 2024 12:01:11 +0000
>Subject: [PATCH] Bug 37946: (follow-up) Update menu style to hide
>Content-Type: text/plain; charset=utf-8
>
>We shouldn't use hide() to hide the Bootstrap menu. The correct move
>here is to empty the "style" attribute.
>
>Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> koha-tmpl/intranet-tmpl/prog/js/z3950_search.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/z3950_search.js b/koha-tmpl/intranet-tmpl/prog/js/z3950_search.js
>index 96c9b1f8b9..09b6e6d9c0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/z3950_search.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/z3950_search.js
>@@ -77,7 +77,7 @@ $( document ).ready( function() {
>         if( tgt.hasClass("z3950actions")  ) { // direct button click
>             var link = $( "a[title='" + tgt.text() + "']", row );
>             if( link.length == 1) link.click();
>-            row.find('ul.dropdown-menu').hide();
>+            row.find('ul.dropdown-menu').attr("style","");
>             return;
>         } else {
>             if( tgt.prop('nodeName') == 'TD' && !tgt.hasClass("actions") ){
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 37946: 171788 | 171806 | 171828 | 171843 | 171844 | 174567 | 174568