Bugzilla – Attachment 17457 Details for
Bug 8068
acq stats refers to budgets when it should be funds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 8068: Standardize terms used on acquisitions statistics
SIGNED-OFF-Bug-8068-Standardize-terms-used-on-acqu.patch (text/plain), 4.18 KB, created by
Owen Leonard
on 2013-04-15 13:53:08 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 8068: Standardize terms used on acquisitions statistics
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2013-04-15 13:53:08 UTC
Size:
4.18 KB
patch
obsolete
>From 8114710a39d5b54dd77cea10bef794607e9ae0c4 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83@web.de> >Date: Sun, 14 Apr 2013 17:44:43 +0200 >Subject: [PATCH] [SIGNED-OFF] Bug 8068: Standardize terms used on > acquisitions statistics >Content-Type: text/plain; charset="utf-8" > >branch > library >budget > fund >bookseller, supplier > vendor >and capitalization > >To test: >1) Go to Reports > Acquisitions statistics >2) Check the labels and options of the form for correctness. >3) Run a few test searches to make sure functionality is > unchanged. > >Unfortunately, some strings are from the .pl file, so a follow >up moving those to the templates is needed. >To make the changes consistent I have changed them in the .pl file. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../prog/en/modules/reports/acquisitions_stats.tt | 14 +++++++------- > reports/acquisitions_stats.pl | 4 ++-- > 2 files changed, 9 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt >index 159e89a..66302dd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt >@@ -60,11 +60,11 @@ > [% CASE '1' %] Placed on (to) > [% CASE '2' %] Received on (from) > [% CASE '3' %] Received on (to) >- [% CASE '4' %] Supplier >- [% CASE '5' %] Home branch >+ [% CASE '4' %] Vendor >+ [% CASE '5' %] Home library > [% CASE '6' %] Collection > [% CASE '7' %] Item type >- [% CASE '8' %] Budget >+ [% CASE '8' %] Fund > [% CASE '9' %] Sort1 > [% CASE '10' %] Sort2 > [% CASE %] Unknown filter >@@ -173,7 +173,7 @@ > <td><input type="radio" name="Column" value="aqbooksellers.name" /></td> > <td> > <select name="Filter"> >- <option value="">All suppliers</option> >+ <option value="">All vendors</option> > [% FOREACH bookseller IN booksellers %] > <option value="[% bookseller.name %]">[% bookseller.name %]</option> > [% END %] >@@ -181,12 +181,12 @@ > </td> > </tr> > <tr> >- <td>Home branch</td> >+ <td>Home library</td> > <td><input type="radio" name="Line" value="items.homebranch" /></td> > <td><input type="radio" name="Column" value="items.homebranch" /></td> > <td> > <select name="Filter"> >- <option value="" selected="selected">All branches</option> >+ <option value="" selected="selected">All libraries</option> > [% FOREACH branch IN branches %] > <option value="[% branch.branchcode %]">[% branch.branchname %]</option> > [% END %] >@@ -224,7 +224,7 @@ > </tr> > > <tr> >- <td>Budget</td> >+ <td>Fund</td> > <td><input type="radio" name="Line" value="aqbudgets.budget_code" /></td> > <td><input type="radio" name="Column" value="aqbudgets.budget_code" /></td> > <td>[% CGIBudget %]</td> >diff --git a/reports/acquisitions_stats.pl b/reports/acquisitions_stats.pl >index cdc5b9a..8d5cb1d 100755 >--- a/reports/acquisitions_stats.pl >+++ b/reports/acquisitions_stats.pl >@@ -128,7 +128,7 @@ else { > my @select; > my %select; > push @select, ""; >- $select{''} = "All Item Types"; >+ $select{''} = "All item types"; > while ( my ( $value, $desc ) = $req->fetchrow ) { > push @select, $value; > $select{$value} = $desc; >@@ -147,7 +147,7 @@ else { > undef @select; > undef %select; > push @select, ""; >- $select{''} = "All budgets"; >+ $select{''} = "All funds"; > > while ( my ( $value, $desc ) = $req->fetchrow ) { > push @select, $value; >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8068
:
17420
|
17457
|
17593