Attachment 174610 Details for Bug 38441 – Bug 38441: Style updates for staffnotes

[patch] Bug 38441: Style updates for staffnotes

Bug-38441-Style-updates-for-staffnotes.patch (text/plain), 2.60 KB, created by Pedro Amorim on 2024-11-15 16:20:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pedro Amorim

Created: 2024-11-15 16:20:43 UTC

Size: 2.60 KB

patch

obsolete

>From aa8ea9b7032f0fc602b54bfb1437deefd7e9ea65 Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Fri, 15 Nov 2024 11:19:00 -0100
>Subject: [PATCH] Bug 38441: Style updates for staffnotes
>
>- Use pre for staffnotes in staff illview
>- Ensure <pre> has same font-family as rest of the page
>- Render html for staff notes in list. Truncate to 100 chars max
>---
> koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss      | 4 ++++
> koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt | 2 +-
> koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js           | 6 +++++-
> 3 files changed, 10 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>index 40deeaf44d..42ebcc68ff 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>@@ -3868,6 +3868,10 @@ input.renew {
>             max-height: 70vh;
>         }
>     }
>+
>+    pre {
>+        font-family: inherit;
>+    }
> }
> 
> .ill-view-panel {
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>index 59509dc97b..63f85d72f7 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>@@ -743,7 +743,7 @@
>                                 [% IF request.notesstaff %]
>                                     <li class="notesstaff">
>                                         <span class="label notes_staff">Staff notes:</span>
>-                                        <p>[% request.notesstaff | $raw %]</p>
>+                                        <pre>[% request.notesstaff | $raw %]</pre>
>                                     </li>
>                                 [% END %]
>                                 [% IF request.notesopac %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js b/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js
>index 7696424818..6f94a1b46a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js
>@@ -419,7 +419,11 @@ $(document).ready(function() {
>                 "data": "staff_notes",
>                 "orderable": true,
>                 "render": function(data, type, row, meta) {
>-                    return escape_str(data);
>+                    if (data?.length > 100) {
>+                        data = data.substr(0, 100) + '...';
>+                    }
>+
>+                    return data;
>                 }
>             },
>             {
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 38441: 174604 | 174605 | 174606 | 174607 | 174608 | 174609 | 174610 | 174611