Attachment 174639 Details for Bug 38302 – Bug 38302: Add delete confirmation dialog

[patch] Bug 38302: Add delete confirmation dialog

Bug-38302-Add-delete-confirmation-dialog.patch (text/plain), 1.56 KB, created by Yanjun Li on 2024-11-15 23:24:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Yanjun Li

Created: 2024-11-15 23:24:57 UTC

Size: 1.56 KB

patch

obsolete

>From b5df664e86928eef463d3a9febb1d30b276635b5 Mon Sep 17 00:00:00 2001
>From: Yanjun Li <yanjun.li@bywatersolutions.com>
>Date: Mon, 4 Nov 2024 22:21:48 +0000
>Subject: [PATCH] Bug 38302: Add delete confirmation dialog
>
>To test:
>
>1. Create a list in the staff interface
>2. Go to lists
>3. See "Your lists" tab and find "Delete" button in "Actions" col, click "delete", no confirmation dialog pop up
>4. Create another list
>5. Go to lists and view the list detail
>6. See "Edit" dropdown and click "Delete Lists" button, see confirmation dialog pop up
>7. Apply patch
>8. Try step 1 through 3 again
>9. "Delete" button in "actions" column has the same confirmation dialog, and delete function works
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> .../intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt    | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>index c9c06745b1..d8167a1fca 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>@@ -702,6 +702,9 @@
>                 $("body").on("click", ".deleteshelf", function(){
>                     return confirmDelete(MSG_CONFIRM_DELETE_LIST);
>                 });
>+                $("body").on("click", ".delete-list",function(){
>+                    return confirm(_("Are you sure you want to delete this list?"));
>+                });
>             });
>         [% END # /IF op == 'list' %]
> 
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 38302: 173953 | 174052 | 174639 | 174640 | 174719 | 174720