Attachment 174640 Details for Bug 38302 – Bug 38302: (follow-up) Remove duplicate click handler and modify button class

[patch] Bug 38302: (follow-up) Remove duplicate click handler and modify button class

Bug-38302-follow-up-Remove-duplicate-click-handler.patch (text/plain), 2.47 KB, created by Yanjun Li on 2024-11-15 23:24:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Yanjun Li

Created: 2024-11-15 23:24:59 UTC

Size: 2.47 KB

patch

obsolete

>From 2f7a0ba131f8c67e8b00bb7b60dc91c5f63f34c1 Mon Sep 17 00:00:00 2001
>From: Yanjun Li <yanjun.li@bywatersolutions.com>
>Date: Fri, 15 Nov 2024 23:14:55 +0000
>Subject: [PATCH] Bug 38302: (follow-up) Remove duplicate click handler and
> modify button class
>
>This follow-up patch removes the unnecessarily added click handler, and modifies the delete button class. The confirmation dialog and delete function work.
>---
> .../intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt    | 3 ---
> .../prog/en/modules/virtualshelves/tables/shelves_results.tt   | 2 +-
> 2 files changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>index d8167a1fca..c9c06745b1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>@@ -702,9 +702,6 @@
>                 $("body").on("click", ".deleteshelf", function(){
>                     return confirmDelete(MSG_CONFIRM_DELETE_LIST);
>                 });
>-                $("body").on("click", ".delete-list",function(){
>-                    return confirm(_("Are you sure you want to delete this list?"));
>-                });
>             });
>         [% END # /IF op == 'list' %]
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt
>index de301479f3..bc69d39d52 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt
>@@ -54,7 +54,7 @@
>         [%~ action_block = action_block _ '<input type="hidden" name="shelfnumber" value="' _ shelfnumber  _ '" />' ~%]
>         [%~ action_block = action_block _ '<input type="hidden" name="public" value="' _ public _ '" />' ~%]
>         [%~ action_block = action_block _ '<input type="hidden" name="referer" value="list" />' ~%]
>-        [%~ action_block = action_block _ '<button type="submit" class="delete-list btn btn-default btn-xs"><i class="fa fa-trash-can"></i> Delete</button>' ~%]
>+        [%~ action_block = action_block _ '<button type="submit" class="deleteshelf btn btn-default btn-xs"><i class="fa fa-trash-can"></i> Delete</button>' ~%]
>         [%~ action_block = action_block _ '</form>' ~%]
>     [%~ END ~%]
>     [%~ IF public AND allow_transfer ~%]
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 38302: 173953 | 174052 | 174639 | 174640 | 174719 | 174720