Bugzilla – Attachment 174657 Details for
Bug 38469
Circulation returns vulnerable to reflected XSS
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38469: Replace single quotes with double quotes to prevent XSS
Bug-38469-Replace-single-quotes-with-double-quotes.patch (text/plain), 1.74 KB, created by
David Cook
on 2024-11-18 04:48:06 UTC
(
hide
)
Description:
Bug 38469: Replace single quotes with double quotes to prevent XSS
Filename:
MIME Type:
Creator:
David Cook
Created:
2024-11-18 04:48:06 UTC
Size:
1.74 KB
patch
obsolete
>From 6c4db5ac4cace9f043eac13446f86b68865960ab Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Mon, 18 Nov 2024 04:46:31 +0000 >Subject: [PATCH] Bug 38469: Replace single quotes with double quotes to > prevent XSS > >This change replaces single quotes with double quotes to prevent XSS >for particular operations on the circ returns page. > >Test plan: >0. Apply the patch >1. Go to http://localhost:8081/cgi-bin/koha/circ/returns.pl?print_slip=1&reserve_id=1 >2. Note that a pring slip is generated >(you may need to allow popups) > >3. To test the XSS is patched, try the proof-of-concept from the >bug report >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 98a1ea119b..2c31c153f2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -1507,10 +1507,10 @@ > [% IF reserve_id %] > $(".print-slip").on('click', function(e) { > e.preventDefault(); >- Dopop('hold-transfer-slip.pl?reserve_id=[% reserve_id | uri %]'); >+ Dopop("hold-transfer-slip.pl?reserve_id=[% reserve_id | uri %]"); > }); > [% IF print_slip %] >- Dopop('hold-transfer-slip.pl?reserve_id=[% reserve_id | uri %]'); >+ Dopop("hold-transfer-slip.pl?reserve_id=[% reserve_id | uri %]"); > [% END %] > [% END %] > var table_settings = [% TablesSettings.GetTableSettings( 'circ', 'returns', 'checkedintable', 'json' ) | $raw %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38469
:
174657
|
175035
|
176058
|
178075