Attachment 174661 Details for Bug 38465 – Bug 38465: (bug 36454 follow-up) Fix curbside pickup's patron autocomplete

[patch] Bug 38465: (bug 36454 follow-up) Fix curbside pickup's patron autocomplete

Bug-38465-bug-36454-follow-up-Fix-curbside-pickups.patch (text/plain), 1.54 KB, created by Jonathan Druart on 2024-11-18 08:40:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2024-11-18 08:40:49 UTC

Size: 1.54 KB

patch

obsolete

>From 1744cff79a2e7223bc4d7d0632e588e6f967d7f9 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 18 Nov 2024 09:38:18 +0100
>Subject: [PATCH] Bug 38465: (bug 36454 follow-up) Fix curbside pickup's patron
> autocomplete
>
>js-date-format.inc already include those 2 JS files. If had them in
>curbside pickups template because it was the first using dayjs.
>Now it's included in js_includes.inc.
>
>Test plan:
>Configure curbside pickup for your library and go to circ/curbside_pickups.pl
>Last tab, search for a patron
>Without this patch you get a JS error:
> Uncaught TypeError: m.tz is not a function
>With this patch applied the patron autocomplete is fixed
>---
> .../intranet-tmpl/prog/en/modules/circ/curbside_pickups.tt      | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/curbside_pickups.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/curbside_pickups.tt
>index ac3c0d31826..89a8091d951 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/curbside_pickups.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/curbside_pickups.tt
>@@ -516,9 +516,7 @@
>     </div> 
> 
> [% MACRO jsinclude BLOCK %]
>-    [% Asset.js("lib/dayjs/dayjs.min.js") | $raw %]
>     [% Asset.js("lib/dayjs/plugin/isSameOrAfter.js") | $raw %]
>-    [% Asset.js("lib/dayjs/plugin/customParseFormat.js") | $raw %]
>     <script>dayjs.extend(window.dayjs_plugin_isSameOrAfter)</script>
>     <script>dayjs.extend(window.dayjs_plugin_customParseFormat)</script>
>     [% INCLUDE 'calendar.inc' %]
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 38465: 174661