Bugzilla – Attachment 174677 Details for
Bug 38299
Errors with updates caught in C4::Installer should be colored/highlighted
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38299: (follow-up) (discussion) Move failure into same level
Bug-38299-follow-up-discussion-Move-failure-into-s.patch (text/plain), 1.64 KB, created by
Jonathan Druart
on 2024-11-18 10:32:05 UTC
(
hide
)
Description:
Bug 38299: (follow-up) (discussion) Move failure into same level
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-11-18 10:32:05 UTC
Size:
1.64 KB
patch
obsolete
>From 2d17786f225b1d04c6d8a9324b3b958fbf688842 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 13 Nov 2024 12:14:50 +0100 >Subject: [PATCH] Bug 38299: (follow-up) (discussion) Move failure into same > level > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > C4/Installer.pm | 2 +- > installer/data/mysql/updatedatabase.pl | 2 -- > 2 files changed, 1 insertion(+), 3 deletions(-) > >diff --git a/C4/Installer.pm b/C4/Installer.pm >index e70b0142a33..4dfebbf7fe9 100644 >--- a/C4/Installer.pm >+++ b/C4/Installer.pm >@@ -743,8 +743,8 @@ sub run_db_rev { > ); > } > catch { >- say_failure( $outfh, "ERROR: " . $_ ); > $error = $_; >+ say_failure( $outfh, "ERROR: " . $error ); > }; > > close $outfh; >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index f4f43a89c0d..b4a276d05d8 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -24302,7 +24302,6 @@ unless ( $ENV{HTTP_HOST} ) { # Is that correct? > } > for my $e ( @{ $report->{error} } ) { > say Encode::encode_utf8(join "\n", @{$e->{output}}); >- #say_failure( undef, Encode::encode_utf8("ERROR - " . $e->{error}) ); > $error_code = 1; > } > >@@ -24313,7 +24312,6 @@ unless ( $ENV{HTTP_HOST} ) { # Is that correct? > } > for my $e ( @{ $report->{error} } ) { > say Encode::encode_utf8(join "\n", @{$e->{output}}); >- #say_failure( undef, Encode::encode_utf8("ERROR - " . $e->{error}) ); > $error_code = 1; > } > exit $error_code; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38299
:
174250
|
174251
|
174252
|
174254
|
174255
|
174256
|
174259
|
174290
|
174291
|
174292
|
174293
|
174421
|
174423
|
174424
|
174455
|
174673
|
174674
|
174675
|
174676
| 174677