Attachment 174711 Details for Bug 36627 – Bug 36627: (QA follow-up): Add missing tests

[patch] Bug 36627: (QA follow-up): Add missing tests

Bug-36627-QA-follow-up-Add-missing-tests.patch (text/plain), 8.48 KB, created by Jonathan Druart on 2024-11-18 14:48:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2024-11-18 14:48:51 UTC

Size: 8.48 KB

patch

obsolete

>From 0460fbadea8ba5070be88fb1e62587c15cff96d4 Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Tue, 12 Nov 2024 11:46:46 +0000
>Subject: [PATCH] Bug 36627: (QA follow-up): Add missing tests
>
>1) Apply patch
>2) $ yarn api:bundle
>3) $ prove t/db_dependent/Koha/ERM/EUsage/CounterLog.t
>4) $ prove t/db_dependent/api/v1/erm_counter_logs.t
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> t/db_dependent/Koha/ERM/EUsage/CounterLog.t |  63 +++++++
> t/db_dependent/api/v1/erm_counter_logs.t    | 174 ++++++++++++++++++++
> 2 files changed, 237 insertions(+)
> create mode 100755 t/db_dependent/Koha/ERM/EUsage/CounterLog.t
> create mode 100755 t/db_dependent/api/v1/erm_counter_logs.t
>
>diff --git a/t/db_dependent/Koha/ERM/EUsage/CounterLog.t b/t/db_dependent/Koha/ERM/EUsage/CounterLog.t
>new file mode 100755
>index 00000000000..86fef487bc2
>--- /dev/null
>+++ b/t/db_dependent/Koha/ERM/EUsage/CounterLog.t
>@@ -0,0 +1,63 @@
>+#!/usr/bin/perl
>+
>+# This file is part of Koha
>+#
>+# Koha is free software; you can redistribute it and/or modify it
>+# under the terms of the GNU General Public License as published by
>+# the Free Software Foundation; either version 3 of the License, or
>+# (at your option) any later version.
>+#
>+# Koha is distributed in the hope that it will be useful, but
>+# WITHOUT ANY WARRANTY; without even the implied warranty of
>+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>+# GNU General Public License for more details.
>+#
>+# You should have received a copy of the GNU General Public License
>+# along with Koha; if not, see <http://www.gnu.org/licenses>.
>+
>+use Modern::Perl;
>+
>+use Test::More tests => 1;
>+
>+use Koha::Database;
>+use Koha::ERM::EUsage::CounterLog;
>+
>+use t::lib::Mocks;
>+use t::lib::TestBuilder;
>+use Test::MockModule;
>+
>+my $schema  = Koha::Database->new->schema;
>+my $builder = t::lib::TestBuilder->new;
>+
>+subtest 'patron' => sub {
>+    plan tests => 2;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $library = $builder->build( { source => 'Branch' } );
>+    my $patron  = $builder->build_object(
>+        {
>+            class => 'Koha::Patrons',
>+            value => { branchcode => $library->{branchcode} }
>+        }
>+    );
>+
>+    my $counterlog = Koha::ERM::EUsage::CounterLog->new(
>+        {
>+            borrowernumber => $patron->borrowernumber,
>+        }
>+    )->store;
>+
>+    my $p = $counterlog->patron;
>+    is(
>+        ref($p), 'Koha::Patron',
>+        'Koha::ERM::EUsage::CounterLog->patron should return a Koha::Patron'
>+    );
>+    is(
>+        $p->borrowernumber, $patron->borrowernumber,
>+        'Koha::ERM::EUsage::CounterLog->patron should return the correct patron'
>+    );
>+
>+    $schema->storage->txn_rollback;
>+
>+};
>diff --git a/t/db_dependent/api/v1/erm_counter_logs.t b/t/db_dependent/api/v1/erm_counter_logs.t
>new file mode 100755
>index 00000000000..07ead1ba1c8
>--- /dev/null
>+++ b/t/db_dependent/api/v1/erm_counter_logs.t
>@@ -0,0 +1,174 @@
>+#!/usr/bin/env perl
>+
>+# Copyright 2023 PTFS Europe
>+
>+# This file is part of Koha.
>+#
>+# Koha is free software; you can redistribute it and/or modify it
>+# under the terms of the GNU General Public License as published by
>+# the Free Software Foundation; either version 3 of the License, or
>+# (at your option) any later version.
>+#
>+# Koha is distributed in the hope that it will be useful, but
>+# WITHOUT ANY WARRANTY; without even the implied warranty of
>+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>+# GNU General Public License for more details.
>+#
>+# You should have received a copy of the GNU General Public License
>+# along with Koha; if not, see <http://www.gnu.org/licenses>.
>+
>+use Modern::Perl;
>+
>+use Test::More tests => 3;
>+use Test::Mojo;
>+
>+use t::lib::TestBuilder;
>+use t::lib::Mocks;
>+
>+use Koha::ERM::EUsage::CounterLogs;
>+use Koha::Database;
>+
>+my $schema  = Koha::Database->new->schema;
>+my $builder = t::lib::TestBuilder->new;
>+
>+my $t = Test::Mojo->new('Koha::REST::V1');
>+t::lib::Mocks::mock_preference( 'RESTBasicAuth', 1 );
>+
>+subtest 'list() tests' => sub {
>+
>+    plan tests => 17;
>+
>+    $schema->storage->txn_begin;
>+
>+    Koha::ERM::EUsage::CounterLogs->search->delete;
>+
>+    my $librarian = $builder->build_object(
>+        {
>+            class => 'Koha::Patrons',
>+            value => { flags => 2**28 }
>+        }
>+    );
>+    my $password = 'thePassword123';
>+    $librarian->set_password( { password => $password, skip_validation => 1 } );
>+    my $userid = $librarian->userid;
>+
>+    my $patron = $builder->build_object(
>+        {
>+            class => 'Koha::Patrons',
>+            value => { flags => 0 }
>+        }
>+    );
>+
>+    $patron->set_password( { password => $password, skip_validation => 1 } );
>+    my $unauth_userid = $patron->userid;
>+
>+    ## Authorized user tests
>+    # No counter logs, so empty array should be returned
>+    $t->get_ok("//$userid:$password@/api/v1/erm/counter_logs")->status_is(200)->json_is( [] );
>+
>+    my $counter_log = $builder->build_object( { class => 'Koha::ERM::EUsage::CounterLogs' } );
>+
>+    # One counter_log created, should get returned
>+    $t->get_ok("//$userid:$password@/api/v1/erm/counter_logs")->status_is(200)->json_is( [ $counter_log->to_api ] );
>+
>+    my $another_counter_log = $builder->build_object(
>+        {
>+            class => 'Koha::ERM::EUsage::CounterLogs',
>+        }
>+    );
>+
>+    # Two counter_logs created, they should both be returned
>+    $t->get_ok("//$userid:$password@/api/v1/erm/counter_logs")->status_is(200)
>+        ->json_is( [ $counter_log->to_api, $another_counter_log->to_api, ] );
>+
>+    # Return 2 counter logs with patron embeded
>+    $t->get_ok( "//$userid:$password@/api/v1/erm/counter_logs/" => { 'x-koha-embed' => 'patron' } )->status_is(200)
>+        ->json_is(
>+        [
>+            { %{ $counter_log->to_api }, patron => $counter_log->patron->to_api( { user => $librarian } ) },
>+            {
>+                %{ $another_counter_log->to_api },
>+                patron => $another_counter_log->patron->to_api( { user => $librarian } )
>+            }
>+        ]
>+        );
>+
>+    # Warn on unsupported query parameter
>+    $t->get_ok("//$userid:$password@/api/v1/erm/counter_logs?blah=blah")->status_is(400)
>+        ->json_is( [ { path => '/query/blah', message => 'Malformed query string' } ] );
>+
>+    # Unauthorized access
>+    $t->get_ok("//$unauth_userid:$password@/api/v1/erm/counter_logs")->status_is(403);
>+
>+    $schema->storage->txn_rollback;
>+};
>+
>+subtest 'get() tests' => sub {
>+
>+    plan tests => 2;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $counter_log = $builder->build_object( { class => 'Koha::ERM::EUsage::CounterLogs' } );
>+    my $librarian   = $builder->build_object(
>+        {
>+            class => 'Koha::Patrons',
>+            value => { flags => 2**28 }
>+        }
>+    );
>+    my $password = 'thePassword123';
>+    $librarian->set_password( { password => $password, skip_validation => 1 } );
>+    my $userid = $librarian->userid;
>+
>+    my $patron = $builder->build_object(
>+        {
>+            class => 'Koha::Patrons',
>+            value => { flags => 0 }
>+        }
>+    );
>+
>+    $patron->set_password( { password => $password, skip_validation => 1 } );
>+    my $unauth_userid = $patron->userid;
>+
>+    # This get method is not implemented should return 404
>+    $t->get_ok( "//$userid:$password@/api/v1/erm/counter_logs/" . $counter_log->erm_counter_log_id )->status_is(404);
>+
>+    $schema->storage->txn_rollback;
>+};
>+
>+subtest 'delete() tests' => sub {
>+
>+    plan tests => 4;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $librarian = $builder->build_object(
>+        {
>+            class => 'Koha::Patrons',
>+            value => { flags => 2**28 }
>+        }
>+    );
>+    my $password = 'thePassword123';
>+    $librarian->set_password( { password => $password, skip_validation => 1 } );
>+    my $userid = $librarian->userid;
>+
>+    my $patron = $builder->build_object(
>+        {
>+            class => 'Koha::Patrons',
>+            value => { flags => 0 }
>+        }
>+    );
>+
>+    $patron->set_password( { password => $password, skip_validation => 1 } );
>+    my $unauth_userid = $patron->userid;
>+
>+    my $counter_log_id = $builder->build_object( { class => 'Koha::ERM::EUsage::CounterLogs' } )->erm_counter_log_id;
>+
>+    # Attempt to delete fails (route does not exist)
>+    $t->delete_ok("//$unauth_userid:$password@/api/v1/erm/counter_logs/$counter_log_id")->status_is(404);
>+
>+    # Attempt to delete non-existent counter_log
>+    $t->delete_ok("//$userid:$password@/api/v1/erm/counter_logs/$counter_log_id")->status_is(404);
>+
>+    $schema->storage->txn_rollback;
>+};
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 36627: 165029 | 165030 | 165031 | 165054 | 165055 | 165056 | 165057 | 165064 | 165065 | 165066 | 165067 | 165068 | 165070 | 165071 | 165072 | 165073 | 165074 | 165127 | 165128 | 165129 | 165130 | 165131 | 169217 | 169218 | 169219 | 169220 | 169221 | 174066 | 174067 | 174068 | 174069 | 174070 | 174402 | 174706 | 174707 | 174708 | 174709 | 174710 | 174711 | 174712