Bugzilla – Attachment 174716 Details for
Bug 30300
Add patron expiration email to patron messaging preferences
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30300: (QA follow-up) Remove extra return
Bug-30300-QA-follow-up-Remove-extra-return.patch (text/plain), 1005 bytes, created by
Matt Blenkinsop
on 2024-11-18 15:01:50 UTC
(
hide
)
Description:
Bug 30300: (QA follow-up) Remove extra return
Filename:
MIME Type:
Creator:
Matt Blenkinsop
Created:
2024-11-18 15:01:50 UTC
Size:
1005 bytes
patch
obsolete
>From 766895477460ee2a6275a6253668f19e975b4119 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 31 Oct 2024 16:55:21 +0000 >Subject: [PATCH] Bug 30300: (QA follow-up) Remove extra return > >The routine loops on the found transports, if there are none it will simply return, no need to short circuit > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > Koha/Patron.pm | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/Koha/Patron.pm b/Koha/Patron.pm >index c7e2b7782e0..6aebe756605 100644 >--- a/Koha/Patron.pm >+++ b/Koha/Patron.pm >@@ -2650,7 +2650,6 @@ sub queue_notice { > } ); > @message_transports = ( keys %{ $messaging_prefs->{transports} } ); > $letter_code = $messaging_prefs->{transports}->{ $message_transports[0] } unless $letter_code; >- return if ( $params->{message_name} eq 'Patron_Expiry' && !$messaging_prefs ); > } else { > @message_transports = @{$params->{message_transports}}; > } >-- >2.39.3 (Apple Git-146)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30300
:
169860
|
169861
|
169870
|
169871
|
173810
|
173811
|
173812
|
173820
|
173821
|
173822
|
173823
|
174713
|
174714
|
174715
|
174716
|
174717
|
174888
|
176154
|
176155
|
176156
|
176157
|
176158
|
176159