Bugzilla – Attachment 174724 Details for
Bug 38436
Adjust code for column visibility (after DataTables upgrade)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38436: Adjust column names for the holdings tables
Bug-38436-Adjust-column-names-for-the-holdings-tab.patch (text/plain), 14.42 KB, created by
Owen Leonard
on 2024-11-18 15:40:56 UTC
(
hide
)
Description:
Bug 38436: Adjust column names for the holdings tables
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2024-11-18 15:40:56 UTC
Size:
14.42 KB
patch
obsolete
>From 127220f9909c01930f6ac054b7c8859900542c02 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 15 Nov 2024 15:18:38 +0100 >Subject: [PATCH] Bug 38436: Adjust column names for the holdings tables > >Removing the prefix holdings_ and otherholdings_ >Could have been done at the code level but does not seem necessary to >have different column names > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > admin/columns_settings.yml | 116 +++++++++--------- > .../tables/items/catalogue_detail.inc | 58 ++++----- > 2 files changed, 87 insertions(+), 87 deletions(-) > >diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml >index b4f487d965..293a109bf0 100644 >--- a/admin/columns_settings.yml >+++ b/admin/columns_settings.yml >@@ -412,69 +412,69 @@ modules: > default_display_length: 20 > columns: > - >- columnname: holdings_checkbox >+ columnname: checkbox > cannot_be_toggled: 1 > cannot_be_modified: 1 > - >- columnname: holdings_cover_image >+ columnname: cover_image > - >- columnname: holdings_itype >+ columnname: itype > - >- columnname: holdings_holdingbranch >+ columnname: holdingbranch > - >- columnname: holdings_homebranch >+ columnname: homebranch > - >- columnname: holdings_ccode >+ columnname: ccode > - >- columnname: holdings_item_group >+ columnname: item_group > - >- columnname: holdings_itemcallnumber >+ columnname: itemcallnumber > - >- columnname: holdings_enumchron >+ columnname: enumchron > - >- columnname: holdings_status >+ columnname: status > - >- columnname: holdings_lastseen >+ columnname: lastseen > - >- columnname: holdings_issues >+ columnname: issues > is_hidden: 1 > - >- columnname: holdings_renewals >+ columnname: renewals > is_hidden: 1 > - >- columnname: holdings_localuse >+ columnname: localuse > is_hidden: 1 > - >- columnname: holdings_dateaccessioned >+ columnname: dateaccessioned > - >- columnname: holdings_datelastborrowed >+ columnname: datelastborrowed > - >- columnname: holdings_booksellerid >+ columnname: booksellerid > is_hidden: 1 > - >- columnname: holdings_barcode >+ columnname: barcode > - >- columnname: holdings_uri >+ columnname: uri > - >- columnname: holdings_copynumber >+ columnname: copynumber > - >- columnname: holdings_stocknumber >+ columnname: stocknumber > - >- columnname: holdings_materials >+ columnname: materials > - >- columnname: holdings_itemnotes >+ columnname: itemnotes > - >- columnname: holdings_itemnotes_nonpublic >+ columnname: itemnotes_nonpublic > - >- columnname: holdings_hostrecord >+ columnname: hostrecord > - >- columnname: holdings_usedin >+ columnname: usedin > - >- columnname: holdings_course_reserves >+ columnname: course_reserves > - >- columnname: holdings_spinelabel >+ columnname: spinelabel > - >- columnname: holdings_actions >+ columnname: actions > cannot_be_toggled: 1 > cannot_be_modified: 1 > >@@ -482,69 +482,69 @@ modules: > default_display_length: 20 > columns: > - >- columnname: otherholdings_checkbox >+ columnname: checkbox > cannot_be_toggled: 1 > cannot_be_modified: 1 > - >- columnname: otherholdings_cover_image >+ columnname: cover_image > - >- columnname: otherholdings_itype >+ columnname: itype > - >- columnname: otherholdings_holdingbranch >+ columnname: holdingbranch > - >- columnname: otherholdings_homebranch >+ columnname: homebranch > - >- columnname: otherholdings_ccode >+ columnname: ccode > - >- columnname: otherholdings_item_group >+ columnname: item_group > - >- columnname: otherholdings_itemcallnumber >+ columnname: itemcallnumber > - >- columnname: otherholdings_enumchron >+ columnname: enumchron > - >- columnname: otherholdings_status >+ columnname: status > - >- columnname: otherholdings_lastseen >+ columnname: lastseen > - >- columnname: otherholdings_issues >+ columnname: issues > is_hidden: 1 > - >- columnname: otherholdings_renewals >+ columnname: renewals > is_hidden: 1 > - >- columnname: otherholdings_localuse >+ columnname: localuse > is_hidden: 1 > - >- columnname: otherholdings_dateaccessioned >+ columnname: dateaccessioned > - >- columnname: otherholdings_datelastborrowed >+ columnname: datelastborrowed > - >- columnname: otherholdings_booksellerid >+ columnname: booksellerid > is_hidden: 1 > - >- columnname: otherholdings_barcode >+ columnname: barcode > - >- columnname: otherholdings_uri >+ columnname: uri > - >- columnname: otherholdings_copynumber >+ columnname: copynumber > - >- columnname: otherholdings_stocknumber >+ columnname: stocknumber > - >- columnname: otherholdings_materials >+ columnname: materials > - >- columnname: otherholdings_itemnotes >+ columnname: itemnotes > - >- columnname: otherholdings_itemnotes_nonpublic >+ columnname: itemnotes_nonpublic > - >- columnname: otherholdings_hostrecord >+ columnname: hostrecord > - >- columnname: otherholdings_usedin >+ columnname: usedin > - >- columnname: otherholdings_course_reserves >+ columnname: course_reserves > - >- columnname: otherholdings_spinelabel >+ columnname: spinelabel > - >- columnname: otherholdings_actions >+ columnname: actions > cannot_be_toggled: 1 > cannot_be_modified: 1 > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >index 047f095fd5..a8f3d7979f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >@@ -9,39 +9,39 @@ > [% BLOCK build_table %] > <table class="items_table" id="[% tab | html %]_table"> > <thead> >- <th id="[% tab | html %]_checkbox" data-colname="[% tab | html %]_checkbox" class="NoSort"></th> >+ <th id="[% tab | html %]_checkbox" data-colname="checkbox" class="NoSort"></th> > [% IF Koha.Preference('LocalCoverImages') %] >- <th id="[% tab | html %]_cover_image" data-colname="[% tab | html %]_cover_image">Cover image</th> >+ <th id="[% tab | html %]_cover_image" data-colname="cover_image">Cover image</th> > [% END %] >- [% IF ( item_level_itypes ) %]<th id="[% tab | html %]_itype" data-colname="[% tab | html %]_itype">Item type</th>[% END %] >- <th id="[% tab | html %]_holdingbranch" data-colname="[% tab | html %]_holdingbranch">Current library</th> >- <th id="[% tab | html %]_homebranch" data-colname="[% tab | html %]_homebranch">Home library</th> >- <th id="[% tab | html %]_ccode" data-colname="[% tab | html %]_ccode">Collection</th> >+ [% IF ( item_level_itypes ) %]<th id="[% tab | html %]_itype" data-colname="itype">Item type</th>[% END %] >+ <th id="[% tab | html %]_holdingbranch" data-colname="holdingbranch">Current library</th> >+ <th id="[% tab | html %]_homebranch" data-colname="homebranch">Home library</th> >+ <th id="[% tab | html %]_ccode" data-colname="ccode">Collection</th> > [% IF Koha.Preference('EnableItemGroups') %] >- <th id="[% tab | html %]_item_group" data-colname="[% tab | html %]_item_group">Item group</th> >+ <th id="[% tab | html %]_item_group" data-colname="item_group">Item group</th> > [% END %] >- <th id="[% tab | html %]_itemcallnumber" data-colname="[% tab | html %]_itemcallnumber">Call number</th> >- <th id="[% tab | html %]_enumchron" data-colname="[% tab | html %]_enumchron">Serial enumeration / chronology</th> >- <th id="[% tab | html %]_status" data-colname="[% tab | html %]_status">Status</th> >- <th id="[% tab | html %]_lastseen" data-colname="[% tab | html %]_lastseen">Last seen</th> >- <th id="[% tab | html %]_issues" data-colname="[% tab | html %]_issues">Checkouts</th> >- <th id="[% tab | html %]_renewals" data-colname="[% tab | html %]_renewals">Renewals</th> >- <th id="[% tab | html %]_localuse" data-colname="[% tab | html %]_localuse">Local uses</th> >- <th id="[% tab | html %]_dateaccessioned" data-colname="[% tab | html %]_dateaccessioned">Date accessioned</th> >- <th id="[% tab | html %]_datelastborrowed" data-colname="[% tab | html %]_datelastborrowed">Date last borrowed</th> >- <th id="[% tab | html %]_booksellerid" data-colname="[% tab | html %]_booksellerid">Source of acquisition</th> >- <th id="[% tab | html %]_barcode" data-colname="[% tab | html %]_barcode">Barcode</th> >- <th id="[% tab | html %]_uri" data-colname="[% tab | html %]_uri">URL</th> >- <th id="[% tab | html %]_copynumber" data-colname="[% tab | html %]_copynumber">Copy number</th> >- <th id="[% tab | html %]_stocknumber" data-colname="[% tab | html %]_stocknumber">Inventory number</th> >- <th id="[% tab | html %]_materials" data-colname="[% tab | html %]_materials">Materials specified</th> >- <th id="[% tab | html %]_itemnotes" data-colname="[% tab | html %]_itemnotes">Public notes</th> >- <th id="[% tab | html %]_itemnotes_nonpublic" data-colname="[% tab | html %]_itemnotes_nonpublic">Non-public notes</th> >- [% IF Koha.Preference('EasyAnalyticalRecords') %]<th id="[% tab | html %]_hostrecord" data-colname="[% tab | html %]_hostrecord">Host records</th>[% END %] >- [% IF ( analyze ) %]<th id="[% tab | html %]_usedin" data-colname="[% tab | html %]_usedin">Used in</th><th></th>[% END %] >- [% IF Koha.Preference('UseCourseReserves') %]<th id="[% tab | html %]_course_reserves" data-colname="[% tab | html %]_course_reserves">Course reserves</th>[% END %] >- [% IF ( SpineLabelShowPrintOnBibDetails ) %]<th id="[% tab | html %]_spinelabel" data-colname="[% tab | html %]_spinelabel" class="NoSort">Spine label</th>[% END %] >- [% IF ( CAN_user_editcatalogue_edit_items ) %]<th id="[% tab | html %]_actions" data-colname="[% tab | html %]_actions" class="NoSort noExport"> </th>[% END %] >+ <th id="[% tab | html %]_itemcallnumber" data-colname="itemcallnumber">Call number</th> >+ <th id="[% tab | html %]_enumchron" data-colname="enumchron">Serial enumeration / chronology</th> >+ <th id="[% tab | html %]_status" data-colname="status">Status</th> >+ <th id="[% tab | html %]_lastseen" data-colname="lastseen">Last seen</th> >+ <th id="[% tab | html %]_issues" data-colname="issues">Checkouts</th> >+ <th id="[% tab | html %]_renewals" data-colname="renewals">Renewals</th> >+ <th id="[% tab | html %]_localuse" data-colname="localuse">Local uses</th> >+ <th id="[% tab | html %]_dateaccessioned" data-colname="dateaccessioned">Date accessioned</th> >+ <th id="[% tab | html %]_datelastborrowed" data-colname="datelastborrowed">Date last borrowed</th> >+ <th id="[% tab | html %]_booksellerid" data-colname="booksellerid">Source of acquisition</th> >+ <th id="[% tab | html %]_barcode" data-colname="barcode">Barcode</th> >+ <th id="[% tab | html %]_uri" data-colname="uri">URL</th> >+ <th id="[% tab | html %]_copynumber" data-colname="copynumber">Copy number</th> >+ <th id="[% tab | html %]_stocknumber" data-colname="stocknumber">Inventory number</th> >+ <th id="[% tab | html %]_materials" data-colname="materials">Materials specified</th> >+ <th id="[% tab | html %]_itemnotes" data-colname="itemnotes">Public notes</th> >+ <th id="[% tab | html %]_itemnotes_nonpublic" data-colname="itemnotes_nonpublic">Non-public notes</th> >+ [% IF Koha.Preference('EasyAnalyticalRecords') %]<th id="[% tab | html %]_hostrecord" data-colname="hostrecord">Host records</th>[% END %] >+ [% IF ( analyze ) %]<th id="[% tab | html %]_usedin" data-colname="usedin">Used in</th><th></th>[% END %] >+ [% IF Koha.Preference('UseCourseReserves') %]<th id="[% tab | html %]_course_reserves" data-colname="course_reserves">Course reserves</th>[% END %] >+ [% IF ( SpineLabelShowPrintOnBibDetails ) %]<th id="[% tab | html %]_spinelabel" data-colname="spinelabel" class="NoSort">Spine label</th>[% END %] >+ [% IF ( CAN_user_editcatalogue_edit_items ) %]<th id="[% tab | html %]_actions" data-colname="actions" class="NoSort noExport"> </th>[% END %] > </tr> > </thead> > </table> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38436
:
174587
|
174588
|
174589
|
174590
|
174591
|
174592
|
174593
|
174594
|
174595
|
174634
|
174641
|
174642
|
174688
|
174689
|
174690
|
174691
|
174692
|
174693
|
174694
|
174695
|
174696
|
174697
|
174698
|
174699
|
174700
|
174701
|
174702
|
174721
|
174722
|
174723
|
174724
|
174725
|
174726
|
174727
|
174728
|
174729
|
174730
|
174731
|
174732
|
174733
|
174734
|
174735
|
174736
|
174740
|
174741
|
174742
|
174743
|
174744
|
174745
|
174746
|
174747
|
174748
|
174749
|
174750
|
174751
|
174752
|
174753
|
174754
|
174755
|
174756
|
174766
|
174767
|
174768
|
174769
|
174770
|
174771
|
174772
|
174773
|
174774
|
174775
|
174776
|
174777
|
174778
|
174779
|
174780
|
174781
|
174782
|
174821
|
174967