Bugzilla – Attachment 174758 Details for
Bug 38446
Permission error for additional fields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38446: Allow those with ERM permissions to access extended attributes
Bug-38446-Allow-those-with-ERM-permissions-to-acce.patch (text/plain), 7.76 KB, created by
Matt Blenkinsop
on 2024-11-18 17:34:53 UTC
(
hide
)
Description:
Bug 38446: Allow those with ERM permissions to access extended attributes
Filename:
MIME Type:
Creator:
Matt Blenkinsop
Created:
2024-11-18 17:34:53 UTC
Size:
7.76 KB
patch
obsolete
>From f3fce75db7656dc10c9f18b9ae680141459acd63 Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> >Date: Mon, 18 Nov 2024 17:32:18 +0000 >Subject: [PATCH] Bug 38446: Allow those with ERM permissions to access > extended attributes > >Test plan: >1. Log in as superlibrarian >2. Activate ERM >3. Add a new additional field for Licences under cgi-bin/koha/admin/additional-fields.pl >4. Go to ERM Module >5. Add a Licence and use the new additional field >6. Search for a user, for example borrowernumber=17 >7. Give permissions for erm , acquisition and catalogue (staff access) >8. Log in with this account >9. Go to ERM Module >10. Try to edit the licence with the additional field you have created in step 5 >11. Apply patch and run yarn api:bundle and then restart_all >12. Repeat steps 9 and 10 >13. The permissions error should vanish >--- > .../paths/extended_attribute_types.yaml | 4 +- > yarn.lock | 61 +------------------ > 2 files changed, 4 insertions(+), 61 deletions(-) > >diff --git a/api/v1/swagger/paths/extended_attribute_types.yaml b/api/v1/swagger/paths/extended_attribute_types.yaml >index eba7aec9017..f115dec0e36 100644 >--- a/api/v1/swagger/paths/extended_attribute_types.yaml >+++ b/api/v1/swagger/paths/extended_attribute_types.yaml >@@ -59,4 +59,6 @@ > $ref: "../swagger.yaml#/definitions/error" > x-koha-authorization: > permissions: >- parameters: manage_additional_fields >+ - parameters: >+ - manage_additional_fields >+ - erm: 1 >diff --git a/yarn.lock b/yarn.lock >index 275b7299e57..9ab64d6bdc8 100755 >--- a/yarn.lock >+++ b/yarn.lock >@@ -2377,11 +2377,6 @@ ansi-styles@^6.1.0: > resolved "https://registry.yarnpkg.com/ansi-styles/-/ansi-styles-6.2.1.tgz#0e62320cf99c21afff3b3012192546aacbfb05c5" > integrity sha512-bN798gFfQX+viw3R7yrGWRqnrN2oRkEkUjjl4JNn4E8GxxbjtG3FbrEIIY3l8/hrwUwIeCZvi4QuOTP4MErVug== > >-ansi-styles@~1.0.0: >- version "1.0.0" >- resolved "https://registry.yarnpkg.com/ansi-styles/-/ansi-styles-1.0.0.tgz#cb102df1c56f5123eab8b67cd7b98027a0279178" >- integrity sha512-3iF4FIKdxaVYT3JqQuY3Wat/T2t7TRbbQ94Fu50ZUCbLy4TFbTzr90NOHQodQkNqmeEGCw8WbeP78WNi6SKYUA== >- > ansi-wrap@0.1.0, ansi-wrap@^0.1.0: > version "0.1.0" > resolved "https://registry.yarnpkg.com/ansi-wrap/-/ansi-wrap-0.1.0.tgz#a82250ddb0015e9a27ca82e82ea603bbfa45efaf" >@@ -3290,15 +3285,6 @@ chalk@^4.0.0, chalk@^4.1.0, chalk@^4.1.2: > ansi-styles "^4.1.0" > supports-color "^7.1.0" > >-chalk@~0.4.0: >- version "0.4.0" >- resolved "https://registry.yarnpkg.com/chalk/-/chalk-0.4.0.tgz#5199a3ddcd0c1efe23bc08c1b027b06176e0c64f" >- integrity sha512-sQfYDlfv2DGVtjdoQqxS0cEZDroyG8h6TamA6rvxwlrU5BaSLDx9xhatBYl2pxZ7gmpNaPFVwBtdGdu5rQ+tYQ== >- dependencies: >- ansi-styles "~1.0.0" >- has-color "~0.1.0" >- strip-ansi "~0.1.0" >- > check-more-types@^2.24.0: > version "2.24.0" > resolved "https://registry.yarnpkg.com/check-more-types/-/check-more-types-2.24.0.tgz#1420ffb10fd444dcfc79b43891bbfffd32a84600" >@@ -4563,13 +4549,6 @@ encodeurl@~1.0.2: > resolved "https://registry.yarnpkg.com/encodeurl/-/encodeurl-1.0.2.tgz#ad3ff4c86ec2d029322f5a02c3a9a606c95b3f59" > integrity sha512-TPJXq8JqFaVYm2CWmPvnP2Iyo4ZSM7/QKcSmuMLDObfpH5fi7RUGmd/rTDf+rut/saiDiQEeVTNgAmJEdAOx0w== > >-encoding@^0.1.11: >- version "0.1.13" >- resolved "https://registry.yarnpkg.com/encoding/-/encoding-0.1.13.tgz#56574afdd791f54a8e9b2785c0582a2d26210fa9" >- integrity sha512-ETBauow1T35Y/WZMkio9jiM0Z5xjHHmJ4XmjZOq1l/dXz3lr2sRn87nJy20RupqSh1F2m3HHPSp8ShIPQJrJ3A== >- dependencies: >- iconv-lite "^0.6.2" >- > end-of-stream@^1.0.0, end-of-stream@^1.1.0: > version "1.4.4" > resolved "https://registry.yarnpkg.com/end-of-stream/-/end-of-stream-1.4.4.tgz#5ae64a5f45057baf3626ec14da0ca5e4b2431eb0" >@@ -5513,13 +5492,6 @@ getpass@^0.1.1: > dependencies: > assert-plus "^1.0.0" > >-gettext-parser@1.1.0: >- version "1.1.0" >- resolved "https://registry.yarnpkg.com/gettext-parser/-/gettext-parser-1.1.0.tgz#2c5a6638d893934b9b55037d0ad82cb7004b2679" >- integrity sha512-zL3eayB0jF+cr6vogH/VJKoKcj7uQj2TPByaaj6a4k/3elk9iq7fiwCM2FqdzS/umo021RetSanVisarzeb9Wg== >- dependencies: >- encoding "^0.1.11" >- > glob-parent@^3.1.0: > version "3.1.0" > resolved "https://registry.yarnpkg.com/glob-parent/-/glob-parent-3.1.0.tgz#9e6af6299d8d3bd2bd40430832bd113df906c5ae" >@@ -5865,11 +5837,6 @@ has-bigints@^1.0.1, has-bigints@^1.0.2: > resolved "https://registry.yarnpkg.com/has-bigints/-/has-bigints-1.0.2.tgz#0871bd3e3d51626f6ca0966668ba35d5602d6eaa" > integrity sha512-tSvCKtBr9lkF0Ex0aQiP9N+OpV4zi2r/Nee5VkRDbaqv35RLYMzbwQfFSZZH0kR+Rd6302UJZ2p/bJCEoR3VoQ== > >-has-color@~0.1.0: >- version "0.1.7" >- resolved "https://registry.yarnpkg.com/has-color/-/has-color-0.1.7.tgz#67144a5260c34fc3cca677d041daf52fe7b78b2f" >- integrity sha512-kaNz5OTAYYmt646Hkqw50/qyxP2vFnTVu5AQ1Zmk22Kk5+4Qx6BpO8+u7IKsML5fOsFk0ZT0AcCJNYwcvaLBvw== >- > has-flag@^3.0.0: > version "3.0.0" > resolved "https://registry.yarnpkg.com/has-flag/-/has-flag-3.0.0.tgz#b5d454dc2199ae225699f3467e5a07f3b955bafd" >@@ -6170,7 +6137,7 @@ iconv-lite@0.4.24: > dependencies: > safer-buffer ">= 2.1.2 < 3" > >-iconv-lite@^0.6.2, iconv-lite@^0.6.3: >+iconv-lite@^0.6.3: > version "0.6.3" > resolved "https://registry.yarnpkg.com/iconv-lite/-/iconv-lite-0.6.3.tgz#a52f80bf38da1952eb5c681790719871a1a72501" > integrity sha512-4fCk79wshMdzMp2rH06qWrJE4iolqLhCUH+OiuIgU++RB0+94NlDL81atO7GX55uUKueo0txHNtvEyI6D7WdMw== >@@ -7885,14 +7852,6 @@ node-sass-tilde-importer@^1.0.2: > dependencies: > find-parent-dir "^0.3.0" > >-nomnom@1.8.1: >- version "1.8.1" >- resolved "https://registry.yarnpkg.com/nomnom/-/nomnom-1.8.1.tgz#2151f722472ba79e50a76fc125bb8c8f2e4dc2a7" >- integrity sha512-5s0JxqhDx9/rksG2BTMVN1enjWSvPidpoSgViZU4ZXULyTe+7jxcCRLB6f42Z0l1xYJpleCBtSyY6Lwg3uu5CQ== >- dependencies: >- chalk "~0.4.0" >- underscore "~1.6.0" >- > normalize-package-data@^2.3.2, normalize-package-data@^2.5.0: > version "2.5.0" > resolved "https://registry.yarnpkg.com/normalize-package-data/-/normalize-package-data-2.5.0.tgz#e66db1838b200c1dfc233225d12cb36520e234a8" >@@ -8586,14 +8545,6 @@ pluralize@^8.0.0: > resolved "https://registry.yarnpkg.com/pluralize/-/pluralize-8.0.0.tgz#1a6fa16a38d12a1901e0320fa017051c539ce3b1" > integrity sha512-Nc3IT5yHzflTfbjgqWcCPpo7DaKy4FnpB0l/zCAW0Tc7jxAiuqSxHasntB3D7887LSrA93kDJ9IXovxJYxyLCA== > >-po2json@^0.4.5: >- version "0.4.5" >- resolved "https://registry.yarnpkg.com/po2json/-/po2json-0.4.5.tgz#47bb2952da32d58a1be2f256a598eebc0b745118" >- integrity sha512-JH0hgi1fC0t9UvdiyS7kcVly0N1WNey4R2YZ/jPaxQKYm6Cfej7ZTgiEy8LP2JwoEhONceiNS8JH5mWPQkiXeA== >- dependencies: >- gettext-parser "1.1.0" >- nomnom "1.8.1" >- > pofile@^1.1.0: > version "1.1.1" > resolved "https://registry.yarnpkg.com/pofile/-/pofile-1.1.1.tgz#a581df04a6fae4941eebd7c1211dbd43700c5541" >@@ -10460,11 +10411,6 @@ strip-ansi@^7.0.1: > dependencies: > ansi-regex "^6.0.1" > >-strip-ansi@~0.1.0: >- version "0.1.1" >- resolved "https://registry.yarnpkg.com/strip-ansi/-/strip-ansi-0.1.1.tgz#39e8a98d044d150660abe4a6808acf70bb7bc991" >- integrity sha512-behete+3uqxecWlDAm5lmskaSaISA+ThQ4oNNBDTBJt0x2ppR6IPqfZNuj6BLaLJ/Sji4TPZlcRyOis8wXQTLg== >- > strip-bom-string@1.X: > version "1.0.0" > resolved "https://registry.yarnpkg.com/strip-bom-string/-/strip-bom-string-1.0.0.tgz#e5211e9224369fbb81d633a2f00044dc8cedad92" >@@ -11101,11 +11047,6 @@ undeclared-identifiers@^1.1.2: > simple-concat "^1.0.0" > xtend "^4.0.1" > >-underscore@~1.6.0: >- version "1.6.0" >- resolved "https://registry.yarnpkg.com/underscore/-/underscore-1.6.0.tgz#8b38b10cacdef63337b8b24e4ff86d45aea529a8" >- integrity sha512-z4o1fvKUojIWh9XuaVLUDdf86RQiq13AC1dmHbTpoyuu+bquHms76v16CjycCbec87J7z0k//SiQVk0sMdFmpQ== >- > undertaker-registry@^1.0.0: > version "1.0.1" > resolved "https://registry.yarnpkg.com/undertaker-registry/-/undertaker-registry-1.0.1.tgz#5e4bda308e4a8a2ae584f9b9a4359a499825cc50" >-- >2.39.3 (Apple Git-146)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38446
:
174758
|
176471
|
183133