Attachment 174852 Details for Bug 38149 – Bug 38149: Make ESLint config compatible with version 9

[patch] Bug 38149: Make ESLint config compatible with version 9

Bug-38149-Make-ESLint-config-compatible-with-versi.patch (text/plain), 1.39 KB, created by Victor Grousset/tuxayo on 2024-11-20 18:58:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Victor Grousset/tuxayo

Created: 2024-11-20 18:58:03 UTC

Size: 1.39 KB

patch

obsolete

>From 176d3196e2d46917a5767f455018aac9f9031a11 Mon Sep 17 00:00:00 2001
>From: Victor Grousset/tuxayo <victor@tuxayo.net>
>Date: Fri, 11 Oct 2024 04:01:04 +0200
>Subject: [PATCH] Bug 38149: Make ESLint config compatible with version 9
>
>Test plan
>1. Apply patch
>2. Start KTD (to check that stuff is installed automatically)
>3. Run this:
>   ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js
>4. You should see errors from prettier in addition to others
>
>QA notes:
>1. Run this:
>   yarn why eslint; yarn why prettier; yarn why eslint-config-prettier; yarn why eslint-plugin-prettier
>2. See that the version are the latest from NPM website
>3. See that they are in devDependencies
>
>Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
>---
> .eslintrc.json | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
>diff --git a/.eslintrc.json b/.eslintrc.json
>index e6bb78fb4c..e7f78af690 100644
>--- a/.eslintrc.json
>+++ b/.eslintrc.json
>@@ -5,7 +5,10 @@
>     },
>     "extends": [
>         "eslint:recommended",
>-        "prettier"
>+        "eslint-config-prettier"
>+    ],
>+    "plugins": [
>+        "eslint-plugin-prettier"
>     ],
>     "rules": {
>         "indent": [
>@@ -19,7 +22,9 @@
>         "semi": [
>             "error",
>             "always"
>+        ],
>+        "prettier/prettier": [
>+            "error"
>         ]
>-    },
>-    "prettier/prettier": "error"
>+    }
> }
>-- 
>2.47.0

Actions: View | Diff | Splinter Review

Attachments on bug 38149: 172682 | 172683 | 173010 | 173011 | 173012 | 174426 | 174427 | 174428 | 174852 | 174853 | 174854