Bugzilla – Attachment 174889 Details for
Bug 38509
Displayed transfer destination is incorrect when a reservation has been found
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38509 - Displayed transfer destination is incorrect when a reservation has been found
Bug-38509---Displayed-transfer-destination-is-inco.patch (text/plain), 2.86 KB, created by
Baptiste Wojtkowski (bwoj)
on 2024-11-21 14:54:47 UTC
(
hide
)
Description:
Bug 38509 - Displayed transfer destination is incorrect when a reservation has been found
Filename:
MIME Type:
Creator:
Baptiste Wojtkowski (bwoj)
Created:
2024-11-21 14:54:47 UTC
Size:
2.86 KB
patch
obsolete
>From 4b880b0272688e9e1f1bd16b01c44fdbe8601679 Mon Sep 17 00:00:00 2001 >From: Baptiste <baptiste.wojtkowski@biblibre.com> >Date: Thu, 21 Nov 2024 15:51:27 +0100 >Subject: [PATCH] Bug 38509 - Displayed transfer destination is incorrect when > a reservation has been found > >TEST PLAN FOR 24.05 (transfers appear to be broken on main atm, code is still invalid on main) > >1 - Place a hold for Henry Acevedo on "39999000001334" (item level), ask for a pickup at centerville >2 - At centerville, transfer the document to fairfield. There will be a pop-up giving you three choices. The first one is "transfer to centerville", which is not the behaviour of the button (the behaviour is correct, we want to perform the transfer and ignore the reservation). The last element of the pop-up is "transfer to: Centerville", which is incorrect too >APPLY PATCH >3 - At centerville, transfer the document to fairfield. There will be a pop-up giving you three choices. The first one is "transfer to fairfield", which is not the behaviour or the button. The last element of the pop-up is "transfer to: Centerville". >--- > .../intranet-tmpl/prog/en/modules/circ/branchtransfers.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt >index 7ce124d600b..ecc780ea132 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt >@@ -118,7 +118,7 @@ > <li class="error">Patron's address is in doubt</li> > [% END %] > </ul> >- <h4>Transfer to: [% Branches.GetName( hold.branchcode ) | html %]</h4> >+ <h4>Transfer to: [% Branches.GetName( tobranchcd ) | html %]</h4> > [% END %] > </div> > >@@ -138,7 +138,7 @@ > [% END %] > [% IF ( reserved ) %] > <input type="hidden" name="op" value="cud-SetTransit" /> >- <button type="submit" class="btn btn-default approve"><i class="fa fa-check"></i> Transfer to [% Branches.GetName( hold.branchcode ) | html %]</button> >+ <button type="submit" class="btn btn-default approve"><i class="fa fa-check"></i> Transfer to [% Branches.GetName( tobranchcd ) | html %]</button> > [% END %] > </form> > </div> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38509
:
174889
|
174890
|
174891