Bugzilla – Attachment 174892 Details for
Bug 38505
CirculateILL checkout broken if item does not have a barcode
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38505: CanBookBeIssued preparation: Add tests for falsy barcode
Bug-38505-CanBookBeIssued-preparation-Add-tests-fo.patch (text/plain), 1.61 KB, created by
Pedro Amorim
on 2024-11-21 15:56:12 UTC
(
hide
)
Description:
Bug 38505: CanBookBeIssued preparation: Add tests for falsy barcode
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2024-11-21 15:56:12 UTC
Size:
1.61 KB
patch
obsolete
>From 3c159ebb9364aa0de14222902200d19b24f47d1b Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Thu, 21 Nov 2024 15:37:09 +0000 >Subject: [PATCH] Bug 38505: CanBookBeIssued preparation: Add tests for falsy > barcode > >prove t/db_dependent/Circulation.t >--- > t/db_dependent/Circulation.t | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index f26069e939..ce38277610 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -2258,7 +2258,7 @@ subtest "AllowRenewalIfOtherItemsAvailable tests" => sub { > } > > subtest 'CanBookBeIssued & AllowReturnToBranch' => sub { >- plan tests => 24; >+ plan tests => 26; > > my $homebranch = $builder->build( { source => 'Branch' } ); > my $holdingbranch = $builder->build( { source => 'Branch' } ); >@@ -2305,6 +2305,10 @@ subtest 'CanBookBeIssued & AllowReturnToBranch' => sub { > set_userenv($homebranch); > ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, 'KohaIsAwesome' ); > ok( $error->{UNKNOWN_BARCODE}, '"KohaIsAwesome" is not a valid barcode as expected.' ); >+ ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, undef ); >+ ok( $error->{UNKNOWN_BARCODE}, 'undef is not a valid barcode as expected.' ); >+ ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, '' ); >+ ok( $error->{UNKNOWN_BARCODE}, '"" is not a valid barcode as expected.' ); > ## Can be issued from homebranch > set_userenv($homebranch); > ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode ); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38505
:
174892
|
174893
|
174894
|
174895
|
174896
|
174924
|
174928
|
174929
|
174930
|
174931
|
174932
|
176256
|
176257
|
176258
|
176259
|
176260