Attachment 174895 Details for Bug 38505 – Bug 38505: CirculateILL: Add UNKNOWN_BARCODE warning message

[patch] Bug 38505: CirculateILL: Add UNKNOWN_BARCODE warning message

Bug-38505-CirculateILL-Add-UNKNOWNBARCODE-warning-.patch (text/plain), 3.27 KB, created by Pedro Amorim on 2024-11-21 15:56:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pedro Amorim

Created: 2024-11-21 15:56:20 UTC

Size: 3.27 KB

patch

obsolete

>From 71fa9cd3c0239e2de5e528e501e3a15fc064773c Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Thu, 21 Nov 2024 13:32:02 +0000
>Subject: [PATCH] Bug 38505: CirculateILL: Add UNKNOWN_BARCODE warning message
>
>Test plan, before applying patches:
>1) Enable ILLModule system preferece.
>2) Create a book ILL request:
>  <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
>3) After creating a Book ILL request, go to its detail page and click on the newly created linked biblio
>4) On the biblio detail, click 'NEW' -> 'New item', add type and home library + current library (dont enter a barcode)
>5) Repeat 2) -> Click confirm request and continue.
>6) Click "Check out" -> If theres a problem with the patron (expired or max checkouts hit) it'll say "A problem with patron occurred". Fix that adn click c"check out" again.
>7) Notice the message "An unknown error occurred while trying to checkout the item"
>8) Apply patches. Repeat. Notice the message you now get is 'The bibliographic record's item contains an unknown (or empty) barcode.'.
>
>This patch also adds a link to the respective biblio for Staff members'
>convenience.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>index 3e6790faa9..9ea645c73f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>@@ -183,6 +183,10 @@
>                             <div class="alert alert-warning">
>                                 Local use recorded
>                             </div>
>+                            [% ELSIF whole.value.check_out_errors.error.UNKNOWN_BARCODE %]
>+                            <div class="alert alert-warning">
>+                                The bibliographic record's item contains an unknown (or empty) barcode.
>+                            </div>
>                             [% ELSE %]
>                             <div class="alert alert-warning">
>                                 There was a problem checking this item out, please check for problems with the <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% whole.value.patron.borrowernumber | uri %]">patron's account</a>
>@@ -196,7 +200,7 @@
>                                     <legend>Check out details</legend>
>                                     [% items = whole.value.biblio.items.unblessed %]
>                                     [% IF items.size == 1 %]
>-                                        <p>The bibliographic record for this request already has an item attached to it, you are about to check it out</p>
>+                                        <p><a target="_blank" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% whole.value.biblio.biblionumber | uri %]">The bibliographic record</a> for this request already has an item attached to it, you are about to check it out</p>
>                                     [% ELSE %]
>                                         <p>A bibliographic record for this request exists, but no item. You are about to create an item and check it out</p>
>                                     [% END %]
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 38505: 174892 | 174893 | 174894 | 174895 | 174896 | 174924 | 174928 | 174929 | 174930 | 174931 | 174932