Bugzilla – Attachment 174906 Details for
Bug 38444
Bug 34147 follow-up: add tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38444: (QA follow-up) tidy
Bug-38444-QA-follow-up-tidy.patch (text/plain), 2.80 KB, created by
David Cook
on 2024-11-21 22:57:42 UTC
(
hide
)
Description:
Bug 38444: (QA follow-up) tidy
Filename:
MIME Type:
Creator:
David Cook
Created:
2024-11-21 22:57:42 UTC
Size:
2.80 KB
patch
obsolete
>From feeb859331eca9d2801edd8470720772a7565efc Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Thu, 21 Nov 2024 22:48:14 +0000 >Subject: [PATCH] Bug 38444: (QA follow-up) tidy > >Signed-off-by: David Cook <dcook@prosentient.com.au> >--- > t/db_dependent/selenium/patrons_search.t | 19 ++++++++++++------- > 1 file changed, 12 insertions(+), 7 deletions(-) > >diff --git a/t/db_dependent/selenium/patrons_search.t b/t/db_dependent/selenium/patrons_search.t >index 76cadfb10d..b5f508b9dd 100755 >--- a/t/db_dependent/selenium/patrons_search.t >+++ b/t/db_dependent/selenium/patrons_search.t >@@ -63,8 +63,8 @@ my $firstname = q|<strong>fir's"tname</strong> \123 â¤|; > my $address = q|<strong>add'res"s</strong> \123 â¤|; > my $email = q|a<strong>bad_email</strong>@example\123 â¤.com|; > my ( >- $attribute_type, $attribute_type_searchable_1, $attribute_type_searchable_2, >- $attribute_type_searchable_not_default, $patron_category, $library >+ $attribute_type, $attribute_type_searchable_1, $attribute_type_searchable_2, >+ $attribute_type_searchable_not_default, $patron_category, $library > ); > sub setup { > $patron_category = $builder->build_object( >@@ -75,9 +75,7 @@ sub setup { > ); > push @cleanup, $patron_category; > >- $library = $builder->build_object( >- { class => 'Koha::Libraries', value => { branchname => $branchname } } >- ); >+ $library = $builder->build_object( { class => 'Koha::Libraries', value => { branchname => $branchname } } ); > push @cleanup, $library; > > my @patrons; >@@ -360,14 +358,21 @@ subtest 'Search patrons' => sub { > > plan tests => 1; > >- $patron_category->replace_library_limits( [$library->id] ); >+ $patron_category->replace_library_limits( [ $library->id ] ); > C4::Context->set_preference( 'PatronsPerPage', 5 ); > $driver->get( $base_url . "/members/members-home.pl" ); > clear_filters(); > $s->fill_form( { 'search_patron_filter' => 'test_patron' } ); > $s->submit_form; > sleep $DT_delay && $s->wait_for_ajax; >- is( $driver->find_element('//div[@id="'.$table_id.'_info"]')->get_text, sprintf('Showing 1 to %s of %s entries (filtered from %s total entries)', $PatronsPerPage, 26, $total_number_of_patrons), 'Search works when category of patrons is limited to a library we are not signed in at' ); >+ is( >+ $driver->find_element( '//div[@id="' . $table_id . '_info"]' )->get_text, >+ sprintf( >+ 'Showing 1 to %s of %s entries (filtered from %s total entries)', $PatronsPerPage, 26, >+ $total_number_of_patrons >+ ), >+ 'Search works when category of patrons is limited to a library we are not signed in at' >+ ); > > }; > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38444
:
174527
|
174576
|
174905
| 174906