Bugzilla – Attachment 174909 Details for
Bug 38484
Filters on the "Holds to pull" page is broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38484: Remove unused USE and SET
Bug-38484-Remove-unused-USE-and-SET.patch (text/plain), 2.43 KB, created by
Jonathan Druart
on 2024-11-22 07:37:05 UTC
(
hide
)
Description:
Bug 38484: Remove unused USE and SET
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-11-22 07:37:05 UTC
Size:
2.43 KB
patch
obsolete
>From 7449e727cc144e93200722ac55b6c8f307286302 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 22 Nov 2024 08:36:38 +0100 >Subject: [PATCH] Bug 38484: Remove unused USE and SET > >And tidy >--- > .../prog/en/modules/circ/pendingreserves.tt | 28 +++++++++---------- > 1 file changed, 13 insertions(+), 15 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >index 6da9f47985a..8769a5be973 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >@@ -1,5 +1,4 @@ > [% USE raw %] >-[% USE To %] > [% USE Asset %] > [% USE Koha %] > [% USE KohaDates %] >@@ -322,22 +321,21 @@ > } > > $(document).ready(function() { >- [% SET libraries = Branches.all %] >- let filters_options = { >- [5] : (table_dt) => get_options(table_dt.column(5)), >- [10] : (table_dt) => get_options(table_dt.column(10)), >- [11] : (table_dt) => get_options(table_dt.column(11)), >- [15] : (table_dt) => get_options(table_dt.column(15)), >- }; >+ let filters_options = { >+ [5] : (table_dt) => get_options(table_dt.column(5)), >+ [10] : (table_dt) => get_options(table_dt.column(10)), >+ [11] : (table_dt) => get_options(table_dt.column(11)), >+ [15] : (table_dt) => get_options(table_dt.column(15)), >+ }; > > >- var table_settings = [% TablesSettings.GetTableSettings('circ', 'holds', 'holds-to-pull', 'json') | $raw %]; >- var holdst = KohaTable("holdst", { >- "pagingType": "full_numbers", >- "columnDefs": [ >- { "orderable": false, "searchable": false, "targets": [ 'NoSort' ] }, >- ], >- }, table_settings, true, null, filters_options); >+ var table_settings = [% TablesSettings.GetTableSettings('circ', 'holds', 'holds-to-pull', 'json') | $raw %]; >+ var holdst = KohaTable("holdst", { >+ "pagingType": "full_numbers", >+ "columnDefs": [ >+ { "orderable": false, "searchable": false, "targets": [ 'NoSort' ] }, >+ ], >+ }, table_settings, true, null, filters_options); > }); > </script> > [% END %] >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38484
:
174788
|
174806
|
174907
|
174908
| 174909