Attachment 174957 Details for Bug 33296 – Bug 33296: Linker should search for authority records with an appropriate 008/14,15,16 value

[patch] Bug 33296: Linker should search for authority records with an appropriate 008/14,15,16 value

Bug-33296-Linker-should-search-for-authority-recor.patch (text/plain), 3.44 KB, created by Janusz Kaczmarek on 2024-11-23 16:01:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Janusz Kaczmarek

Created: 2024-11-23 16:01:26 UTC

Size: 3.44 KB

patch

obsolete

>From 99658a8103a67739bb0ee142bc1f1bb2a43e801a Mon Sep 17 00:00:00 2001
>From: Janusz Kaczmarek <januszop@gmail.com>
>Date: Sat, 23 Nov 2024 15:42:15 +0000
>Subject: [PATCH] Bug 33296: Linker should search for authority records with an
> appropriate 008/14,15,16 value
>
>In an authority record, 008/14 = 'a' says it's appropriate for use as a
>main or added entry (1xx, 7xx), 008/15 = 'a' says it's appropriate for
>use as a subject entry, and 008/16 = 'a' says it's appropriate for use
>as a series entry.
>
>Test plan:
>==========
>1. Have a standard KTD environment. Have the patches from Bug 38494
>   applied.
>2. Set AutoLinkBiblios system preference to 'Do', and
>   ConsiderHeadingUse to 'Do'.
>3. Open an existing bibliographic record and add a new field 650. In
>   subfield $a enter 'Application software' (without quotes), and in $x
>   'Development.' (with final dot).
>4. Save the record. In Normal view control that the entered subject
>   heading entry has been linked with the existing authority record (note
>   the magnifying glass icon).
>5. Apply the patch ; restart all.
>6. Repeat p. 3. Note that this time the newly entered subject heading
>   entry has not been linked with the existing authority record. This is
>   because the authority record has 008/15 = '|' while 'a' is required with
>   ConsiderHeadingUse.
>7. In Authorities, find the record for 'Application
>   software--Development.' Modify it by changing 008/15 to 'a' (Heading
>   use--subject added entry).
>8. Return to the bibliographic record. Open it in the editor and save.
>   The subject heading entry for 'Application software--Development.'
>   should now be linked with the existing authority record.
>---
> C4/Heading.pm | 25 ++++++++++++++++++++++---
> 1 file changed, 22 insertions(+), 3 deletions(-)
>
>diff --git a/C4/Heading.pm b/C4/Heading.pm
>index 653cd9636d..4d8956c17c 100644
>--- a/C4/Heading.pm
>+++ b/C4/Heading.pm
>@@ -22,7 +22,7 @@ use Modern::Perl;
> use MARC::Field;
> use C4::Context;
> use Module::Load qw( load );
>-use List::Util qw( none );
>+use List::Util qw( none first );
> 
> =head1 NAME
> 
>@@ -222,6 +222,25 @@ sub _search {
>         push @value, $thesaurus;
>     }
> 
>+    if ( C4::Context->preference('ConsiderHeadingUse') ) {
>+        my $marcflavour = C4::Context->preference('marcflavour');
>+        my $biblio_tag  = $self->{'field'}->tag;
>+        if ( $marcflavour eq 'MARC21' ) {
>+            my $heading_use_search_field =
>+                  $biblio_tag =~ /^[127]/ ? 'Heading-use-main-or-added-entry'
>+                : $biblio_tag =~ /^6/     ? 'Heading-use-subject-added-entry'
>+                : $biblio_tag =~ /^[48]/  ? 'Heading-use-series-added-entry'
>+                :                           undef;
>+            if ($heading_use_search_field) {
>+                push @marclist,  $heading_use_search_field;
>+                push @and_or,    'and';
>+                push @excluding, '';
>+                push @operator,  'is';
>+                push @value,     'a';
>+            }
>+        }
>+    }
>+
>     require Koha::SearchEngine::QueryBuilder;
>     require Koha::SearchEngine::Search;
> 
>@@ -253,8 +272,8 @@ sub _search {
>         )
>       )
>     {
>-        pop @value;
>-        push @value, 'notdefined';
>+        my $thesaurus_idx = first { $marclist[$_] eq 'thesaurus' } 0 .. $#marclist;
>+        $value[$thesaurus_idx] = 'notdefined';
>         $search_query =
>           $builder->build_authorities_query_compat( \@marclist, \@and_or,
>             \@excluding, \@operator, \@value, $self->{'auth_type'},
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 33296: 174957 | 174958 | 174959 | 174960