Bugzilla – Attachment 174981 Details for
Bug 38070
Regression in print notices
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38070: Revert class change so notices print one per page
Bug-38070-Revert-class-change-so-notices-print-one.patch (text/plain), 1.53 KB, created by
Andrew Fuerste-Henry
on 2024-11-25 16:30:41 UTC
(
hide
)
Description:
Bug 38070: Revert class change so notices print one per page
Filename:
MIME Type:
Creator:
Andrew Fuerste-Henry
Created:
2024-11-25 16:30:41 UTC
Size:
1.53 KB
patch
obsolete
>From 101aac8bf43ea68986dfa5147bdac1b1f686c843 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 3 Oct 2024 15:46:41 +0100 >Subject: [PATCH] Bug 38070: Revert class change so notices print one per page > >This patch reverses the bootstrap 5 find and replace for the 'message' >class. > >In this file the message class didn't refer to the bootstrap themeing >but rather is used for applying `page-break-after: always` to these >elements. > >Test plan >1) Line up some print notices >2) Run gather_print_notices.pl with html file output >3) Open the output file >4) Print the page to invoke the page break css >5) Note that with the patch each notice is on it's own page, without the > patch all the notices run one after the other on the same page. > >Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt >index c1e36c9b69..3c81202854 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt >@@ -22,7 +22,7 @@ > </head> > <body id="batch_print-notices" class="batch"> > [% FOREACH message IN messages %] >- <div class="alert alert-info"> >+ <div class="message"> > [% IF ( message.is_html ) %] > [% message.content | $raw %] > [% ELSE %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38070
:
172361
| 174981