Bugzilla – Attachment 175031 Details for
Bug 38452
Inventory tool barcodes should not be case sensitive
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38452: Add lc() for case insensitivity
Bug-38452-Add-lc-for-case-insensitivity.patch (text/plain), 1.29 KB, created by
ByWater Sandboxes
on 2024-11-29 16:59:03 UTC
(
hide
)
Description:
Bug 38452: Add lc() for case insensitivity
Filename:
MIME Type:
Creator:
ByWater Sandboxes
Created:
2024-11-29 16:59:03 UTC
Size:
1.29 KB
patch
obsolete
>From 4d13707bf616b93dff26f4dc5caee69b2afc1ac5 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 15 Nov 2024 23:03:59 +0000 >Subject: [PATCH] Bug 38452: Add lc() for case insensitivity > >To test: >1. Create an item give it a barcode like 'abc123'; >2. Try creating a 2nd item with a barcode: 'ABC123', you get an error 'Error saving item: Barcode must be unique.' >3. Checkin the item 'ABC123', the 'abc123' item successfully checks in. >4. The case doesn't seem to matter elsewhere in Koha ( check-in, checkout, searching, batch tools ) >5. Try the inventory tool and use 'ABC123'. The barcode is not found. >6. APPLY PATCH, restart_all >7. Try the inventory tool again with both 'abc123' and 'ABC123', they should now both work. > >Signed-off-by: Kevin ONeil <kco.ipad@ipad.com> >--- > tools/inventory.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/tools/inventory.pl b/tools/inventory.pl >index 1c94183596..acebf6aa61 100755 >--- a/tools/inventory.pl >+++ b/tools/inventory.pl >@@ -191,7 +191,7 @@ if ( $op eq 'cud-inventory' > for my $barcode (@uploadedbarcodes) { > next unless $barcode; > >- $barcode = barcodedecode($barcode); >+ $barcode = lc(barcodedecode($barcode)); > > ++$lines_read; > if (length($barcode)>$barcode_size) { >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38452
:
174638
|
175031
|
175451
|
175452
|
175455
|
175477
|
176310