Bugzilla – Attachment 175045 Details for
Bug 38594
Table settings for courses reserves not working in the OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38594: Fix table settings on the course reserves tables - OPAC
Bug-38594-Fix-table-settings-on-the-course-reserve.patch (text/plain), 2.93 KB, created by
Jonathan Druart
on 2024-12-02 10:25:55 UTC
(
hide
)
Description:
Bug 38594: Fix table settings on the course reserves tables - OPAC
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-12-02 10:25:55 UTC
Size:
2.93 KB
patch
obsolete
>From 8730f50fc9fd88ea05001bac6cf7ba11b06a8d8c Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 2 Dec 2024 11:22:53 +0100 >Subject: [PATCH] Bug 38594: Fix table settings on the course reserves tables - > OPAC > >We are passing the columns settings, but KohaTable is expecting the >table settings. > >Test plan: >Hide some columns for the course reserves table at the OPAC >Define a course, add 1+ items >Go to the OPAC, "Course reserves" >Notice that with this patch the columns are correctly hidden by default. >--- > .../opac-tmpl/bootstrap/en/modules/opac-course-details.tt | 4 ++-- > .../opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt >index 2ffc06914c5..27836cf3c6a 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt >@@ -125,7 +125,7 @@ > [% INCLUDE 'columns_settings.inc' %] > <script> > $(document).ready(function() { >- columns_settings = [% TablesSettings.GetColumns( 'opac', 'course_items', 'course-items-table', 'json' ) | $raw %]; >+ table_settings = [% TablesSettings.GetTableSettings( 'opac', 'course_items', 'course-items-table', 'json' ) | $raw %]; > KohaTable("#course-items-table", { > "dom": '<"top"<"table_controls"f>>t', > "sorting": [[ 1, "asc" ]], >@@ -139,7 +139,7 @@ > "columnDefs": [ > { "className": 'dtr-control', "orderable": false, "targets": -1 }, > ], >- }, columns_settings ); >+ }, table_settings ); > }); > </script> > [% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt >index 0f51bfbe8c5..ee3c7f95dfd 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt >@@ -74,7 +74,7 @@ > [% INCLUDE 'columns_settings.inc' %] > <script> > $(document).ready(function() { >- columns_settings = [% TablesSettings.GetColumns( 'opac', 'course_list', 'course_reserves_table', 'json' ) | $raw %] >+ table_settings = [% TablesSettings.GetTableSettings( 'opac', 'course_list', 'course_reserves_table', 'json' ) | $raw %] > KohaTable("#course_reserves_table", { > "dom": '<"top"<"table_controls"f>>rt<"clear">', > "sorting": [[ 1, "asc" ]], >@@ -91,7 +91,7 @@ > "cColumnDefs": [ > { "className": 'dtr-control', "orderable": false, "targets": -1 }, > ], >- }, columns_settings ); >+ }, table_settings ); > }); > </script> > [% END %] >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38594
:
175045
|
175046
|
175055
|
175056
|
175060
|
175061