Attachment 175075 Details for Bug 37993 – Bug 37993: (QA follow-up) Use submit form link asset guideline JS16

[patch] Bug 37993: (QA follow-up) Use submit form link asset guideline JS16

Bug-37993-QA-follow-up-Use-submit-form-link-asset-.patch (text/plain), 4.37 KB, created by Martin Renvoize (ashimema) on 2024-12-03 13:02:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-12-03 13:02:30 UTC

Size: 4.37 KB

patch

obsolete

>From 7d3b9db1783c6face04a9577fe830a76a55c50e4 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 3 Dec 2024 12:30:10 +0000
>Subject: [PATCH] Bug 37993: (QA follow-up) Use submit form link asset
> guideline JS16
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../prog/en/modules/acqui/basket.tt           | 19 ++++---------------
> 1 file changed, 4 insertions(+), 15 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>index 66cbcc6419e..67075bb91d0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>@@ -111,26 +111,14 @@
> 
>                                         [% IF Koha.Preference('EDIFACT') && ediaccount %]
>                                             <div class="btn-group">
>-                                                [% IF eans.count == 1 %]
>-                                                    <form action="/cgi-bin/koha/acqui/basket.pl" method="post">
>-                                                        [% INCLUDE 'csrf-token.inc' %]
>-                                                        <input type="hidden" name="op" value="cud-ediorder" />
>-                                                        <input type="hidden" name="basketno" value="[% basketno | html %]" />
>-                                                        <input type="hidden" name="ean" value="[% eans.0 | html %]" />
>-                                                        <button type="submit" class="btn btn-default" id="ediorderbutton"><i class="fa fa-download"></i> Create EDIFACT order</button>
>-                                                    </form>
>+                                                [% IF eans.size == 1 %]
>+                                                    <a class="btn btn-default btn-xs submit-form-link" href="#" data-ean="[% eans.0 | html %]" data-basketno="[% basketno | html %]" data-action="basket.pl" data-method="post" data-op="cud-ediorder"><i class="fa fa-download"></i> Create EDIFACT order</a>
>                                                 [% ELSE %]
>                                                     <button class="btn btn-default dropdown-toggle" data-bs-toggle="dropdown" aria-expanded="false" id="ediorderbutton"><i class="fa fa-download"></i> Create EDIFACT order</button>
>                                                     <ul class="dropdown-menu">
>                                                         [% FOREACH eanacct IN eans %]
>                                                         <li>
>-                                                        <form action="/cgi-bin/koha/acqui/basket.pl" method="post">
>-                                                            [% INCLUDE 'csrf-token.inc' %]
>-                                                            <input type="hidden" id="basketno" value="[% basketno | html %]" name="basketno" />
>-                                                            <input type="hidden" value="cud-ediorder" name="op" />
>-                                                            <input type="hidden" name="ean" value="[% eanacct.ean | html %]">
>-                                                            <button type="submit" class="btn btn-default">[% eanacct.branch.branchname | html %] ([% eanacct.ean | html %]) [% IF eanacct.description %][[% eanacct.description | html %]][% END %]</button>
>-                                                        </form>
>+                                                            <a class="btn btn-default btn-xs submit-form-link" href="#" data-ean="[% eanacct.ean | html %]" data-basketno="[% basketno | html %]" data-action="basket.pl" data-method="post" data-op="cud-ediorder">[% eanacct.branch.branchname | html %] ([% eanacct.ean | html %]) [% IF eanacct     .description %][[% eanacct.description | html %]][% END %]</a>
>                                                         </li>
>                                                         [% END %]
>                                                     </ul>
>@@ -1026,6 +1014,7 @@
> 
> [% MACRO jsinclude BLOCK %]
>     [% Asset.js("js/acquisitions-menu.js") | $raw %]
>+    [% Asset.js("js/form-submit.js") | $raw %]
>     [% INCLUDE 'datatables.inc' %]
>     [% INCLUDE 'columns_settings.inc' %]
>     [% Asset.js("js/acq.js") | $raw %]
>-- 
>2.47.1

Actions: View | Diff | Splinter Review

Attachments on bug 37993: 175024 | 175025 | 175026 | 175027 | 175042 | 175043 | 175044 | 175069 | 175070 | 175072 | 175073 | 175074 | 175075 | 175076 | 175081 | 175132