Bugzilla – Attachment 175095 Details for
Bug 38607
CART notice issues
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38607: CART notice issues
Bug-38607-CART-notice-issues.patch (text/plain), 3.99 KB, created by
Lisette Scheer
on 2024-12-03 20:46:12 UTC
(
hide
)
Description:
Bug 38607: CART notice issues
Filename:
MIME Type:
Creator:
Lisette Scheer
Created:
2024-12-03 20:46:12 UTC
Size:
3.99 KB
patch
obsolete
>From b16d216b34e626fe326a3cf1a06ced5f751f2386 Mon Sep 17 00:00:00 2001 >From: Lisette Scheer <lisette@bywatersolutions.com> >Date: Tue, 3 Dec 2024 19:07:54 +0000 >Subject: [PATCH] Bug 38607: CART notice issues > >When sending carts, spaces are removed from subtitles and if there is a shelving location but no call number there isn't a space between the shelving location and the item barcode. > >Test plan: >1. Find an item with a subtitle >2. Make sure the account you're using has an email address >3. Add it to your cart in the OPAC >4. Send the cart to yourself >5. In the staff interface, create and run this report: >SELECT * FROM message_queue; >6. Notice the subtitle has no spaces and there isn't a space between the location and the barcode >7. Apply the patch >8. Go to the notice in the staff interface and select "view default notice" >9. Copy the default into your notice and save. >10. Repeat steps 4 & 5 >11. Observe that the spacing is now correct. >--- > installer/data/mysql/en/mandatory/sample_notices.yml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/installer/data/mysql/en/mandatory/sample_notices.yml b/installer/data/mysql/en/mandatory/sample_notices.yml >index e054a5a0fa9..7a74c715d95 100644 >--- a/installer/data/mysql/en/mandatory/sample_notices.yml >+++ b/installer/data/mysql/en/mandatory/sample_notices.yml >@@ -2569,7 +2569,7 @@ tables: > - "[% IF ( comment ) %]<hr><br>[% comment | html | html_line_break %]<br><br>[% END %]<hr>" > - "<ol>[% FOREACH biblio IN biblios %]<li>" > - "[% biblio.title | html %]" >- - "[% IF ( biblio.subtitle ) %][% FOREACH subtitle IN biblio.subtitle.split(' | ') %][% subtitle | html %][% END %][% END %][% biblio.part_number | html %] [% biblio.part_name | html %]<br>" >+ - "[% IF ( biblio.subtitle ) %][% FOREACH subtitle IN biblio.subtitle.split('\ \ |\ \ ') %][% subtitle | html %][% END %][% END %][% biblio.part_number | html %] [% biblio.part_name | html %]<br>" > - "[% IF ( biblio.author || biblio.get_marc_contributors.size ) %]Author(s): [% IF ( biblio.author ) %][% biblio.author | html %][% END %][% IF ( biblio.get_marc_contributors ) %][% IF ( biblio.author ) %]; [% END %][% FOREACH author IN biblio.get_marc_contributors %][% FOREACH subfield IN author.MARCAUTHOR_SUBFIELDS_LOOP %][% subfield.separator | html %][% subfield.value | html %][% END %][% UNLESS ( loop.last ) %];[% END %][% END %][% END %]<br>[% END %]" > - "[% SET biblioitem = biblio.biblioitem %][% IF ( biblioitem.isbn ) %]ISBN: [% FOREACH isbn IN biblioitem.isbn %][% isbn | html %][% UNLESS ( loop.last ) %]; [% END %][% END %]<br>[% END %]" > - "[% IF ( biblioitem.publishercode ) %]Published by: [% biblioitem.publishercode | html %][% IF ( biblioitem.publicationyear ) %] in [% biblioitem.publicationyear | html %][% END %][% IF ( biblioitem.pages ) %], [% biblioitem.pages | html %][% END %]<br>[% END %]" >@@ -2583,7 +2583,7 @@ tables: > - "[% IF ( biblioitem.url ) %]URL: [% biblioitem.url | html %]<br>[% END %]" > - "<a href='[% Koha.Preference('OpacBaseUrl') %]/cgi-bin/koha/opac-detail.pl?biblionumber=[% biblio.biblionumber | html %]'>View in online catalog</a>" > - "[% IF ( biblio.items.count > 0 ) %]<br>Items: <ul>[% FOREACH item IN biblio.items %]<li>[% Branches.GetName( item.holdingbranch ) | html %]" >- - "[% IF ( item.location ) %], [% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.location', authorised_value => item.location ) | html %][% END %][% IF item.itemcallnumber %]([% item.itemcallnumber | html %])[% END %][% item.barcode | html %]</li>[% END %]</ul>[% END %]" >+ - "[% IF ( item.location ) %], [% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.location', authorised_value => item.location ) | html %] [% END %][% IF item.itemcallnumber %]([% item.itemcallnumber | html %]) [% END %][% item.barcode | html %]</li>[% END %]</ul>[% END %]" > - "<hr></li>[% END %]</ol>" > > - module: preservation >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38607
: 175095