Bugzilla – Attachment 175132 Details for
Bug 37993
Having a single EDI EAN account produces a bad redirect
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37993: (QA follow-up) Fix tooltip and disabled display
Bug-37993-QA-follow-up-Fix-tooltip-and-disabled-di.patch (text/plain), 3.05 KB, created by
Martin Renvoize (ashimema)
on 2024-12-04 09:55:45 UTC
(
hide
)
Description:
Bug 37993: (QA follow-up) Fix tooltip and disabled display
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-12-04 09:55:45 UTC
Size:
3.05 KB
patch
obsolete
>From 295579f8d14e2a74401d9fae6c9a5feafd45da2b Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 4 Dec 2024 09:53:46 +0000 >Subject: [PATCH] Bug 37993: (QA follow-up) Fix tooltip and disabled display > >This patch re-arranges the button markup slightly to properly style the >disabled 'Create EDI Order' button when there are no EAN's defined for >the library. It also moves the tooltip to the container btn-group >element to ensure the tooltip works even though the button itself is >disabled. >--- > .../intranet-tmpl/prog/en/modules/acqui/basket.tt | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >index 9a0d4e23109..729661670b4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >@@ -110,10 +110,13 @@ > [% PROCESS csv_export %] > > [% IF Koha.Preference('EDIFACT') && ediaccount %] >+ [% UNLESS eans.size %] >+ <div class="btn-group" title="You must define an EAN in Administration -> Library EANs"> >+ <button class="btn btn-default btn-xs disabled" disabled="disabled" href="#"><i class="fa fa-download"></i> Create EDIFACT order</button> >+ </div> >+ [% ELSE %] > <div class="btn-group"> >- [% UNLESS eans.size %] >- <a title="You must define an EAN in Administration -> Library EANs" class="btn btn-default btn-xs" disabled="disabled" href="#"><i class="fa fa-download"></i> Create EDIFACT order</a> >- [% ELSIF eans.size == 1 %] >+ [% IF eans.size == 1 %] > <a class="btn btn-default btn-xs submit-form-link" href="#" data-ean="[% eans.0 | html %]" data-basketno="[% basketno | html %]" data-action="basket.pl" data-method="post" data-op="cud-ediorder"><i class="fa fa-download"></i> Create EDIFACT order</a> > [% ELSE %] > <button class="btn btn-default dropdown-toggle" data-bs-toggle="dropdown" aria-expanded="false" id="ediorderbutton"><i class="fa fa-download"></i> Create EDIFACT order</button> >@@ -126,6 +129,7 @@ > </ul> > [% END %] > </div> >+ [% END %] > [% END %] > > [% IF ( active && books_loop ) %] >-- >2.47.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37993
:
175024
|
175025
|
175026
|
175027
|
175042
|
175043
|
175044
|
175069
|
175070
|
175072
|
175073
|
175074
|
175075
|
175076
|
175081
| 175132