Attachment 175208 Details for Bug 35654 – Bug 35654: (follow-up) Remove unneeded code and comment

[patch] Bug 35654: (follow-up) Remove unneeded code and comment

Bug-35654-follow-up-Remove-unneeded-code-and-comme.patch (text/plain), 1.13 KB, created by Brendan Lawlor on 2024-12-04 20:51:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Brendan Lawlor

Created: 2024-12-04 20:51:02 UTC

Size: 1.13 KB

patch

obsolete

>From 40d77e2c92c7bf115abe1707b6782ad736b96884 Mon Sep 17 00:00:00 2001
>From: Brendan Lawlor <blawlor@clamsnet.org>
>Date: Wed, 4 Dec 2024 18:58:41 +0000
>Subject: [PATCH] Bug 35654: (follow-up) Remove unneeded code and comment
>
>This patch removes old code that was used for direct SQL
>---
> misc/cronjobs/delete_items.pl | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/misc/cronjobs/delete_items.pl b/misc/cronjobs/delete_items.pl
>index b79341c7d7..8e09271f54 100755
>--- a/misc/cronjobs/delete_items.pl
>+++ b/misc/cronjobs/delete_items.pl
>@@ -22,11 +22,8 @@ use Pod::Usage   qw( pod2usage );
> 
> use Koha::Script -cron;
> use C4::Biblio qw( DelBiblio );
>-use C4::Context;
> use Koha::Items;
> 
>-my $dbh = C4::Context->dbh();
>-
> my @where          = ();
> my $verbose        = 0;
> my $help           = 0;
>@@ -58,7 +55,7 @@ my $deleted_string = $commit ? "Deleted" : "Would have deleted";
> 
> my $items = Koha::Items->search( \$where_clause );
> 
>-DELITEM: while ( my $item = $items->next ){ #$sth->fetchrow_hashref() ) {
>+DELITEM: while ( my $item = $items->next ){
> 
>     my $holdings_count = $item->biblio->items->count;
>     my $error;
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 35654: 174480 | 174529 | 175193 | 175194 | 175195 | 175208 | 175209