Bugzilla – Attachment 175338 Details for
Bug 30568
Make patron name fields more flexible
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30568: Add classes to patron title components
Bug-30568-Add-classes-to-patron-title-components.patch (text/plain), 3.32 KB, created by
Andrew Fuerste-Henry
on 2024-12-09 22:01:19 UTC
(
hide
)
Description:
Bug 30568: Add classes to patron title components
Filename:
MIME Type:
Creator:
Andrew Fuerste-Henry
Created:
2024-12-09 22:01:19 UTC
Size:
3.32 KB
patch
obsolete
>From 664f287d078c1a6a8b8d4f9c80651fd2507c20c5 Mon Sep 17 00:00:00 2001 >From: Andrew Fuerste Henry <andrew@bywatersolutions.com> >Date: Mon, 9 Dec 2024 21:58:17 +0000 >Subject: [PATCH] Bug 30568: Add classes to patron title components > >to test: >1 - have a patron with data in firstname, surname, middle name, othernames, and preferred name >2 - view patron name in patron record and other places where patron.title is used, confirm lack of HTML markup >3 - apply patch, restart services >4 - reload patron record and other pages around Koha, confirm name display hasn't changed but the composite parts of the name are now marked with classes >--- > .../intranet-tmpl/prog/en/includes/patron-title.inc | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc >index 72d4472a83..3a9661020f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc >@@ -67,16 +67,16 @@ > [%- END -%] > [%- IF display_patron_name -%] > [%- IF data.category_type == 'I' -%] >- [%- data.surname | html -%] [%- IF data.othernames -%] ([%- data.othernames | html -%])[%- END -%] >+ <span class='surname'>[%- data.surname | html -%]</span> [%- IF data.othernames -%] <span class='othernames'>([%- data.othernames | html -%])</span>[%- END -%] > [%- ELSIF invert_name -%] >- [%- data.title | $raw -%][%- data.surname | html -%][%- IF ( data.preferred_name ) -%], [% data.preferred_name | html -%][%- END -%][%- IF data.middle_name -%] [% data.middle_name | html -%][%- END -%][%- IF data.othernames -%] ([%- data.othernames | html -%])[%- END -%] >+ [%- data.title | $raw -%]<span class='surname'>[%- data.surname | html -%]</span>[%- IF ( data.preferred_name ) -%], <span class='preferred_name'>[% data.preferred_name | html -%]</span>[%- END -%][%- IF data.middle_name -%] <span class='middle_name'>[% data.middle_name | html -%]</span>[%- END -%][%- IF data.othernames -%] <span class='othernames'>([%- data.othernames | html -%])</span>[%- END -%] > [%- ELSE -%] >- [%- data.title | $raw -%][%- data.preferred_name | html %][%- IF data.middle_name -%] [% data.middle_name | html -%][%- END -%][%- IF data.othernames -%] ([%- data.othernames | html -%]) [%- END -%] [% data.surname | html -%] >+ [%- data.title | $raw -%]<span class='preferred_name'>[%- data.preferred_name | html %]</span>[%- IF data.middle_name -%] <span class='middle_name'>[% data.middle_name | html -%]</span>[%- END -%][%- IF data.othernames -%] <span class='othernames'>([%- data.othernames | html -%])</span> [%- END -%] <span class='surname'>[% data.surname | html -%]</span> > [%- END -%] >- [%- IF display_cardnumber AND data.cardnumber -%] ([%- data.cardnumber | html -%])[%- END -%] >+ [%- IF display_cardnumber AND data.cardnumber -%] <span class='cardnumber'>([%- data.cardnumber | html -%])</span>[%- END -%] > [%- ELSIF display_cardnumber -%] > [%- IF data.cardnumber -%][%# FIXME Cardnumber should always be defined, right? -%] >- [%- data.cardnumber | html -%] >+ <span class='cardnumber'>[%- data.cardnumber | html -%]</span> > [%- END -%] > [%- ELSE -%] > <span>A patron from library [%- Branches.GetName( patron.branchcode ) | html -%]</span> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30568
:
175338
|
175351
|
175365
|
175910
|
175911