Bugzilla – Attachment 175339 Details for
Bug 38659
Cannot set a new suggestion manager when editing a suggestion
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38659: Fix select_manager function when there are no tabs
Bug-38659-Fix-selectmanager-function-when-there-ar.patch (text/plain), 1.87 KB, created by
Lucas Gass (lukeg)
on 2024-12-09 22:04:19 UTC
(
hide
)
Description:
Bug 38659: Fix select_manager function when there are no tabs
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2024-12-09 22:04:19 UTC
Size:
1.87 KB
patch
obsolete
>From d564f5ce0f78cd68f4949424c5624bfabd890d68 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Mon, 9 Dec 2024 22:02:19 +0000 >Subject: [PATCH] Bug 38659: Fix select_manager function when there are no tabs > >To test: >1. Have multiple staff you have permissions to be a purchase suggestion manager. >2. Make some suggestions. >3. Edit a suggestion, go down to 'Select manager'. >4. Select a new manager, notice the new one name is not populated. >5. Save the record, the manager is not changed to the new one. >6. APPLY PATCH >7. Try again steps 3-6, but this time the manager field should populate and the new manager should be saved when you save the suggestion. >8. Go through the test plan on Bug 38659. >--- > .../prog/en/modules/suggestion/suggestion.tt | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index da3d7a66f8..5e00e522d2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -1303,8 +1303,13 @@ > <script> > function select_manager(borrowernumber, borrower) { > let tab = $('#suggestiontabs .active table').data('tab-name'); >- var managedby_name = $("#managedby_name-"+tab); >- var managedby = $("#managedby-"+tab); >+ if ( tab ) { >+ var managedby_name = $("#managedby_name-"+tab); >+ var managedby = $("#managedby-"+tab); >+ } else { >+ var managedby_name = $("#managedby_name"); >+ var managedby = $("#managedby"); >+ } > managedby_name.empty(); > managedby.val(''); > var borrowername = borrower.firstname + ' ' + borrower.surname; >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38659
:
175339
|
175346
|
175568