Bugzilla – Attachment 175365 Details for
Bug 30568
Make patron name fields more flexible
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30568: Add classes to component name parts in intranet
Bug-30568-Add-classes-to-component-name-parts-in-i.patch (text/plain), 4.52 KB, created by
Andrew Fuerste-Henry
on 2024-12-10 18:30:42 UTC
(
hide
)
Description:
Bug 30568: Add classes to component name parts in intranet
Filename:
MIME Type:
Creator:
Andrew Fuerste-Henry
Created:
2024-12-10 18:30:42 UTC
Size:
4.52 KB
patch
obsolete
>From 1937a3042e4755038eb464f3c325e2306d9cf7f3 Mon Sep 17 00:00:00 2001 >From: Andrew Fuerste Henry <andrew@bywatersolutions.com> >Date: Tue, 10 Dec 2024 18:28:17 +0000 >Subject: [PATCH] Bug 30568: Add classes to component name parts in intranet > >to test: >1 - have a patron with all name parts >2 - load pages with a variety of name displays, confirm lack of classes >3 - apply patch >4 - reload pages from step 2, confirm there are now classes *except for where the name is called with no_html, like a page title >--- > .../prog/en/includes/patron-title.inc | 33 ++++++++++++++----- > 1 file changed, 25 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc >index 72d4472a83..569b4c8a45 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc >@@ -66,17 +66,34 @@ > [%- END -%] > [%- END -%] > [%- IF display_patron_name -%] >- [%- IF data.category_type == 'I' -%] >- [%- data.surname | html -%] [%- IF data.othernames -%] ([%- data.othernames | html -%])[%- END -%] >- [%- ELSIF invert_name -%] >- [%- data.title | $raw -%][%- data.surname | html -%][%- IF ( data.preferred_name ) -%], [% data.preferred_name | html -%][%- END -%][%- IF data.middle_name -%] [% data.middle_name | html -%][%- END -%][%- IF data.othernames -%] ([%- data.othernames | html -%])[%- END -%] >+ [%- IF no_html -%] >+ [%- IF data.category_type == 'I' -%] >+ [%- data.surname | html -%] [%- IF data.othernames -%] ([%- data.othernames | html -%])[%- END -%] >+ [%- ELSIF invert_name -%] >+ [%- data.title | $raw -%][%- data.surname | html -%][%- IF ( data.preferred_name ) -%], [% data.preferred_name | html -%][%- END -%][%- IF data.middle_name -%] [% data.middle_name | html -%][%- END -%][%- IF data.othernames -%] ([%- data.othernames | html -%])[%- END -%] >+ [%- ELSE -%] >+ [%- data.title | $raw -%][%- data.preferred_name | html %][%- IF data.middle_name -%] [% data.middle_name | html -%][%- END -%][%- IF data.othernames -%] ([%- data.othernames | html -%]) [%- END -%] [% data.surname | html -%] >+ [%- END -%] >+ [%- IF display_cardnumber AND data.cardnumber -%] ([%- data.cardnumber | html -%])[%- END -%] > [%- ELSE -%] >- [%- data.title | $raw -%][%- data.preferred_name | html %][%- IF data.middle_name -%] [% data.middle_name | html -%][%- END -%][%- IF data.othernames -%] ([%- data.othernames | html -%]) [%- END -%] [% data.surname | html -%] >+ [%- IF data.category_type == 'I' -%] >+ <span class='surname'>[%- data.surname | html -%]</span> [%- IF data.othernames -%] <span class='othernames'>([%- data.othernames | html -%])</span>[%- END -%] >+ [%- ELSIF invert_name -%] >+ [%- data.title | $raw -%]<span class='surname'>[%- data.surname | html -%]</span>[%- IF ( data.preferred_name ) -%], <span class='preferred_name'>[% data.preferred_name | html -%]</span>[%- END -%][%- IF data.middle_name -%] <span class='middle_name'>[% data.middle_name | html -%]</span>[%- END -%][%- IF data.othernames -%] <span class='othernames'>([%- data.othernames | html -%])</span>[%- END -%] >+ [%- ELSE -%] >+ [%- data.title | $raw -%]<span class='preferred_name'>[%- data.preferred_name | html %]</span>[%- IF data.middle_name -%] <span class='middle_name'>[% data.middle_name | html -%]</span>[%- END -%][%- IF data.othernames -%] <span class='othernames'>([%- data.othernames | html -%])</span> [%- END -%] <span class='surname'>[% data.surname | html -%]</span> >+ [%- END -%] >+ [%- IF display_cardnumber AND data.cardnumber -%] <span class='cardnumber'>([%- data.cardnumber | html -%])</span>[%- END -%] > [%- END -%] >- [%- IF display_cardnumber AND data.cardnumber -%] ([%- data.cardnumber | html -%])[%- END -%] > [%- ELSIF display_cardnumber -%] >- [%- IF data.cardnumber -%][%# FIXME Cardnumber should always be defined, right? -%] >- [%- data.cardnumber | html -%] >+ [%- IF no_html -%] >+ [%- IF data.cardnumber -%][%# FIXME Cardnumber should always be defined, right? -%] >+ [%- data.cardnumber | html -%] >+ [%- END -%] >+ [%- ELSE -%] >+ [%- IF data.cardnumber -%][%# FIXME Cardnumber should always be defined, right? -%] >+ <span class='cardnumber'>[%- data.cardnumber | html -%]</span> >+ [%- END -%] > [%- END -%] > [%- ELSE -%] > <span>A patron from library [%- Branches.GetName( patron.branchcode ) | html -%]</span> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30568
:
175338
|
175351
|
175365
|
175910
|
175911