Bugzilla – Attachment 175377 Details for
Bug 38678
GET /deleted/biblios cannot be filtered on `deleted_on`
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38678: Fix wrong attribute mapping in Koha::Old::Biblio
Bug-38678-Fix-wrong-attribute-mapping-in-KohaOldBi.patch (text/plain), 1.24 KB, created by
Tomás Cohen Arazi (tcohen)
on 2024-12-11 18:10:52 UTC
(
hide
)
Description:
Bug 38678: Fix wrong attribute mapping in Koha::Old::Biblio
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2024-12-11 18:10:52 UTC
Size:
1.24 KB
patch
obsolete
>From 17406345fe03206512a81aff1782bc7c95873c71 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 11 Dec 2024 14:09:40 -0300 >Subject: [PATCH] Bug 38678: Fix wrong attribute mapping in Koha::Old::Biblio > >Because the mapping was defined in the wrong direction, it is not >possible to filter results in `GET /deleted/biblios` neither on the >`deleted_on` attribute, or even the fallback to DB fields when mappings >don't exist, on `timestamp`. > >To test: >1. Apply the regression tests patch >2. Run: > $ ktd --shell > k$ prove t/db_dependent/api/v1/deleted_biblios.t >=> FAIL: A 200 returns a 500 instead >3. Apply this patch >4. Repeat 2 >=> SUCCESS: Tests pass, behavior is correct >5. Sign off :-D > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/Old/Biblio.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Old/Biblio.pm b/Koha/Old/Biblio.pm >index 204f1456479..c2735caa92f 100644 >--- a/Koha/Old/Biblio.pm >+++ b/Koha/Old/Biblio.pm >@@ -126,7 +126,7 @@ sub to_api_mapping { > seriestitle => 'series_title', > copyrightdate => 'copyright_date', > datecreated => 'creation_date', >- deleted_on => 'timestamp', >+ timestamp => 'deleted_on', > }; > } > >-- >2.47.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38678
:
175376
|
175377
|
175669
|
175670
|
175671
|
175672
|
175988
|
175989