Bugzilla – Attachment 175386 Details for
Bug 30095
Allow to change "warn when late" setting in subscriptions batch modification tool
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30095: Add "warn when late" to subscriptions batch mod tool
Bug-30095-Add-warn-when-late-to-subscriptions-batc.patch (text/plain), 4.44 KB, created by
Julian Maurice
on 2024-12-12 09:09:58 UTC
(
hide
)
Description:
Bug 30095: Add "warn when late" to subscriptions batch mod tool
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2024-12-12 09:09:58 UTC
Size:
4.44 KB
patch
obsolete
>From 18cb9e0fbbe3cb24fd01705069571111eef2c21f Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Mon, 14 Feb 2022 15:38:25 +0100 >Subject: [PATCH] Bug 30095: Add "warn when late" to subscriptions batch mod > tool >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch depends on bug 29996 > >Test plan: >1. On the Serials module main page, do a search that return at least 2 > subscriptions >2. Check at least 2 boxes in the first column of the table, then click > on "Edit selected serials" above the table >3. Verify that the table above the form display correct data for the > "Warn when late" column >4. Submit the form without changing anything. Verify that the setting > "warn when late" was not changed for selected subscriptions >5. Repeat steps 1 and 2. Set "Warn when late" to "No" and submit the > form. Verify that the setting "warn when late" was changed to "No" > for all selected subscriptions >6. Repeat steps 1 and 2. Set "Warn when late" to "Yes" and submit the > form. Verify that the setting "warn when late" was changed to "Yes" > for all selected subscriptions > >Sponsored-by: Ãcoles Nationales Supérieures d'Architecture >--- > .../en/modules/serials/subscription-batchedit.tt | 16 ++++++++++++++++ > serials/subscription-batchedit.pl | 1 + > 2 files changed, 17 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-batchedit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-batchedit.tt >index 809f8a0133..049e141fa2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-batchedit.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-batchedit.tt >@@ -53,6 +53,7 @@ > <th>Nonpublic notes</th> > <th>Call number</th> > <th>Create item when receiving</th> >+ <th>Warn when late</th> > <th>Expiration date</th> > </tr> > </thead> >@@ -75,6 +76,13 @@ > <span>No</span> > [% END %] > </td> >+ <td> >+ [% IF subscription.warn_when_late %] >+ <span>Yes</span> >+ [% ELSE %] >+ <span>No</span> >+ [% END %] >+ </td> > <td>[% subscription.enddate | $KohaDates %]</td> > </tr> > [% END %] >@@ -145,6 +153,14 @@ > </select> > > </li> >+ <li> >+ <label for="warn_when_late">Warn when late: </label> >+ <select id="warn_when_late" name="warn_when_late"> >+ <option value="">No change</option> >+ <option value="0">No</option> >+ <option value="1">Yes</option> >+ </select> >+ </li> > <li> > <label for="enddate">Expiration date: </label> > <input type="text" class="flatpickr" id="enddate" name="enddate" placeholder="No change"/> >diff --git a/serials/subscription-batchedit.pl b/serials/subscription-batchedit.pl >index 676905cbba..b1b7e7f909 100755 >--- a/serials/subscription-batchedit.pl >+++ b/serials/subscription-batchedit.pl >@@ -61,6 +61,7 @@ if ( $op eq 'cud-batchedit' ) { > notes => scalar $cgi->param('notes'), > internalnotes => scalar $cgi->param('internalnotes'), > serialsadditems => scalar $cgi->param('serialsadditems'), >+ warn_when_late => scalar $cgi->param('warn_when_late'), > ); > # If we convert a blank string we get todays date, we should only convert enddate if it is not blank > $params{'enddate'} = dt_from_string( scalar $cgi->param('enddate') ) if $cgi->param('enddate'); >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30095
:
130549
| 175386