Bugzilla – Attachment 175460 Details for
Bug 38685
ILL pages have incomplete breadcrumbs
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38685: Remove useless batch_create code
Bug-38685-Remove-useless-batchcreate-code.patch (text/plain), 1.73 KB, created by
Owen Leonard
on 2024-12-13 17:36:32 UTC
(
hide
)
Description:
Bug 38685: Remove useless batch_create code
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2024-12-13 17:36:32 UTC
Size:
1.73 KB
patch
obsolete
>From 0a3bb2bc0a5dce69f2437e54b2114e071ade3620 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Thu, 12 Dec 2024 12:40:05 +0000 >Subject: [PATCH] Bug 38685: Remove useless batch_create code > >This is not used and not needed. >Noticed when evaluating every potential 'op'. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > ill/ill-requests.pl | 2 -- > koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt | 2 +- > 2 files changed, 1 insertion(+), 3 deletions(-) > >diff --git a/ill/ill-requests.pl b/ill/ill-requests.pl >index 37b2979ee8..96a1bdc7c2 100755 >--- a/ill/ill-requests.pl >+++ b/ill/ill-requests.pl >@@ -474,8 +474,6 @@ if ( $backends_available ) { > exit; > } elsif ( $op eq "batch_list" ) { > # Do not remove, it prevents us falling through to the 'else' >- } elsif ( $op eq "batch_create" ) { >- # Do not remove, it prevents us falling through to the 'else' > } else { > $op =~ s/^cud-//; > my $request = Koha::ILL::Requests->find( $params->{illrequest_id} ); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >index 60b8a4a62d..2010031db0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >@@ -969,7 +969,7 @@ > </fieldset> > </form> > </div> >- [% ELSIF op == 'batch_list' || op == 'batch_create' %] >+ [% ELSIF op == 'batch_list' %] > [% INCLUDE 'ill-batch.inc' %] > [% ELSE %] > <!-- Custom Backend Action --> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38685
:
175397
|
175399
|
175400
|
175401
|
175460
|
175461
|
175462
|
175463
|
176273
|
176274
|
176275
|
176276