Bugzilla – Attachment 175619 Details for
Bug 38727
Improve the translatability of the patron categories administration page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38727: Improve translatability in categories.tt
Bug-38727-Improve-translatability-in-categoriestt.patch (text/plain), 5.72 KB, created by
Tomás Cohen Arazi (tcohen)
on 2024-12-17 14:27:10 UTC
(
hide
)
Description:
Bug 38727: Improve translatability in categories.tt
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2024-12-17 14:27:10 UTC
Size:
5.72 KB
patch
obsolete
>From 513297a93483f3686c1ac41ce130c59bee1ca9ef Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 17 Dec 2024 09:50:24 -0300 >Subject: [PATCH] Bug 38727: Improve translatability in categories.tt > >This makes the strings easier to translated for maintaining them as a >whole instead of splitting them > >Bonus 1: it adds a missing dot for consistency. >Bonus 2: makes a string more idiomatic. > >To test: >1. In the categories edit page, check the 3 'If set...' texts >2. Apply this patch and reload >=> SUCCESS: No visual change >3. Sign off :-D > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > .../prog/en/modules/admin/categories.tt | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt >index a162519f98b..1e400992982 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt >@@ -1,6 +1,7 @@ > [% USE raw %] > [% USE Asset %] > [% USE Koha %] >+[% USE KohaSpan %] > [% USE Branches %] > [% USE KohaDates %] > [% USE Price %] >@@ -403,8 +404,9 @@ > [% END %] > </optgroup> > </select> >+ [%- SET pref_BlockExpiredPatronOpacActions_link = '<a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=BlockExpiredPatronOpacActions&ok=Search">BlockExpiredPatronOpacActions</a>' -%] > <div class="hint"> >- Choose which OPAC actions, if any, are blocked for expired patrons of this category. Alternatively, the system preference <a href="/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=BlockExpiredPatronOpacActions">BlockExpiredPatronOpacActions</a> can be used instead. >+ Choose which OPAC actions, if any, should be blocked for expired patrons in this category. Alternatively, you can use the system preference [%- pref_BlockExpiredPatronOpacActions_link | $raw | $KohaSpan -%] instead. > </li> > [% IF ( Koha.Preference('CheckPrevCheckout') == 'softyes' || Koha.Preference('CheckPrevCheckout') == 'softno' ) %] > <li><label for="checkprevcheckout">Check for previous checkouts: </label> >@@ -478,22 +480,25 @@ > <option value="0" selected>No</option> > [% END %] > </select> >- <div class="hint">If <i>Yes</i>, holds placed by patrons of this category will not be given priority</div> >+ <div class="hint">If <i>Yes</i>, holds placed by patrons of this category will not be given priority.</div> > </li> > <li> > <label for="noissuescharge">Checkout charge limit: </label> > <input type="text" pattern="^\d+(\.\d{2})?$" name="noissuescharge" id="noissuescharge" value="[% category.noissuescharge | $Price on_editing => 1 %]" class="decimal" size="3" maxlength="4" /> >- <div class="hint">If set, this will override the global value set in the <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=noissuescharge&ok=Search">noissuescharge</a> preference</div> >+ [%- SET pref_noissuescharge_link = '<a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=noissuescharge&ok=Search">noissuescharge</a>' -%] >+ <div class="hint">If set, this will override the global value set in the [%- pref_noissuescharge_link | $raw | $KohaSpan -%] preference.</div> > </li> > <li> > <label for="noissueschargeguarantees">Guarantees checkout charge limit: </label> > <input type="text" pattern="^\d+(\.\d{2})?$" name="noissueschargeguarantees" id="noissueschargeguarantees" value="[% category.noissueschargeguarantees | $Price on_editing => 1 %]" class="decimal" size="3" maxlength="4" /> >- <div class="hint">If set, this will override the global value set in the <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=noissuescharge&ok=Search">NoIssuesChargeGuarantees</a> preference</div> >+ [%- SET pref_NoIssuesChargeGuarantees_link = '<a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=NoIssuesChargeGuarantees&ok=Search">NoIssuesChargeGuarantees</a>' -%] >+ <div class="hint">If set, this will override the global value set in the [%- pref_NoIssuesChargeGuarantees_link | $raw | $KohaSpan -%] preference.</div> > </li> > <li> > <label for="noissueschargeguarantorswithguarantees">Guarantors with guarantees checkout charge limit: </label> > <input type="text" pattern="^\d+(\.\d{2})?$" name="noissueschargeguarantorswithguarantees" id="noissueschargeguarantorswithguarantees" value="[% category.noissueschargeguarantorswithguarantees | $Price on_editing => 1 %]" class="decimal" size="3" maxlength="4" /> >- <div class="hint">If set, this will override the global value set in the <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=noissuescharge&ok=Search">NoIssuesChargeGuarantorsWithGuarantees</a> preference</div> >+ [%- SET pref_NoIssuesChargeGuarantorsWithGuarantees_link = '<a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=NoIssuesChargeGuarantees&ok=Search">NoIssuesChargeGuarantees</a>' -%] >+ <div class="hint">If set, this will override the global value set in the [%- pref_NoIssuesChargeGuarantorsWithGuarantees_link | $raw | $KohaSpan -%] preference.</div> > </li> > </ol> > </fieldset> >-- >2.47.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38727
:
175609
|
175619
|
176107
|
176675
|
176676