Attachment 175634 Details for Bug 38726 – Bug 38726: (follow-up) Some more {Mm}arc ordering cases

[patch] Bug 38726: (follow-up) Some more {Mm}arc ordering cases

Bug-38726-follow-up-Some-more-Mmarc-ordering-cases.patch (text/plain), 4.49 KB, created by Tomás Cohen Arazi (tcohen) on 2024-12-17 19:54:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2024-12-17 19:54:30 UTC

Size: 4.49 KB

patch

obsolete

>From fcfc86052222d1efee019b03e4bd952d1facadc3 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Tue, 17 Dec 2024 16:53:37 -0300
>Subject: [PATCH] Bug 38726: (follow-up) Some more {Mm}arc ordering cases
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> Koha/MarcOrder.pm                                    | 12 ++++++------
> .../prog/en/modules/admin/marc_order_accounts.tt     |  2 +-
> misc/cronjobs/marc_ordering_process.pl               |  4 ++--
> 3 files changed, 9 insertions(+), 9 deletions(-)
>
>diff --git a/Koha/MarcOrder.pm b/Koha/MarcOrder.pm
>index eb2c13d3a3f..edfe93d1b21 100644
>--- a/Koha/MarcOrder.pm
>+++ b/Koha/MarcOrder.pm
>@@ -251,7 +251,7 @@ sub _create_basket_for_file {
> 
>     $file->_stage_file($params)
> 
>-    Stages a file directly using parameters from a marc ordering account
>+    Stages a file directly using parameters from a MARC ordering account
> 
> =cut
> 
>@@ -267,7 +267,7 @@ sub _stage_file {
> 
>     my $syspref_info = _get_syspref_mappings( $marcrecord, $syspref_name );
> 
>-    Fetches data from a marc record based on the mappings in the syspref MarcFieldsToOrder or MarcItemFieldsToOrder using the fields selected in $fields (array).
>+    Fetches data from a MARC record based on the mappings in the syspref MarcFieldsToOrder or MarcItemFieldsToOrder using the fields selected in $fields (array).
> 
> =cut
> 
>@@ -363,8 +363,8 @@ sub _verify_number_of_fields {
>     });
> 
>     Takes a set of import records and adds biblio records based on the file content.
>-    Params matcher_id and overlay_action are taken from the marc ordering account.
>-    Returns the new or matched biblionumber and the marc record for each import record.
>+    Params matcher_id and overlay_action are taken from the MARC ordering account.
>+    Returns the new or matched biblionumber and the MARC record for each import record.
> 
> =cut
> 
>@@ -388,7 +388,7 @@ sub add_biblio_from_import_record {
>         } if not grep { $_ eq $import_record->import_record_id } @{$import_record_id_selected};
>     }
> 
>-    my $marcrecord   = $import_record->get_marc_record || die "Couldn't translate marc information";
>+    my $marcrecord   = $import_record->get_marc_record || die "Couldn't translate MARC information";
>     my $matches      = $import_record->get_import_record_matches( { chosen => 1 } );
>     my $match        = $matches->count ? $matches->next             : undef;
>     my $biblionumber = $match          ? $match->candidate_match_id : 0;
>@@ -695,7 +695,7 @@ sub import_biblios_list {
>             : '',
>             match_score => $match ? $match->score : 0,
>         );
>-        my $marcrecord = $import_record->get_marc_record || die "couldn't translate marc information";
>+        my $marcrecord = $import_record->get_marc_record || die "couldn't translate MARC information";
> 
>         my $infos = _get_syspref_mappings( $marcrecord, 'MarcFieldsToOrder' );
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_order_accounts.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_order_accounts.tt
>index 3ef12485b3a..4759d6aec21 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_order_accounts.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_order_accounts.tt
>@@ -49,7 +49,7 @@ MARC order accounts
>                     </a>
>                     </div>
>                     [% IF ( accounts ) %]
>-                        <h1>Marc ordering accounts</h1>
>+                        <h1>MARC ordering accounts</h1>
>                         <div class="page-section">
>                             <table>
>                                 <tr>
>diff --git a/misc/cronjobs/marc_ordering_process.pl b/misc/cronjobs/marc_ordering_process.pl
>index 18084ad7245..657203bcdde 100755
>--- a/misc/cronjobs/marc_ordering_process.pl
>+++ b/misc/cronjobs/marc_ordering_process.pl
>@@ -83,7 +83,7 @@ cronlogaction( { info => $command_line_options } );
> $verbose = 1            unless $verbose or $confirm;
> print "Test run only\n" unless $confirm;
> 
>-print "Fetching marc ordering accounts\n" if $verbose;
>+print "Fetching MARC ordering accounts\n" if $verbose;
> my @accounts = Koha::MarcOrderAccounts->search(
>     {},
>     { join => [ 'vendor', 'budget' ] }
>@@ -95,7 +95,7 @@ if ( scalar(@accounts) == 0 ) {
> 
> foreach my $acct (@accounts) {
>     if ($verbose) {
>-        say sprintf "Starting marc ordering process for %s", $acct->vendor->name;
>+        say sprintf "Starting MARC ordering process for %s", $acct->vendor->name;
>         say sprintf "Looking for new files in %s",           $acct->download_directory;
>     }
> 
>-- 
>2.47.1

Actions: View | Diff | Splinter Review

Attachments on bug 38726: 175607 | 175614 | 175616 | 175634