Bugzilla – Attachment 175699 Details for
Bug 38750
Installer process not terminating when nothing to do
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38750: (bug 38385 follow-up) Unblock update process when nothing to do
Bug-38750-bug-38385-follow-up-Unblock-update-proce.patch (text/plain), 1.52 KB, created by
Jonathan Druart
on 2024-12-19 11:25:25 UTC
(
hide
)
Description:
Bug 38750: (bug 38385 follow-up) Unblock update process when nothing to do
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-12-19 11:25:25 UTC
Size:
1.52 KB
patch
obsolete
>From e9dd8039c5fa4ee86b5a82c3b29f82e435d28b7e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 19 Dec 2024 12:24:01 +0100 >Subject: [PATCH] Bug 38750: (bug 38385 follow-up) Unblock update process when > nothing to do > >When we go to installer/install.pl and there is nothing to do we get a "Try again" button and never manage to finish the update. > >https://snipboard.io/TplscJ.jpg > >Test plan: >Go to installer/install.pl >Login >Click next >=> Without this patch you are stuck with a "Try again" button >=> With this patch applied you get a success screen > "Everything went okay. Update done." >--- > koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt >index f6dd94594dc..164d0ba0c5c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt >@@ -451,7 +451,7 @@ > </ul> > [% END %] > >- [% UNLESS error OR atomic_updates.error OR has_update_errors %] >+ [% UNLESS error OR atomic_updates.error.size OR has_update_errors %] > <p>Everything went okay. Update done.</p> > <p><a href="install.pl?step=3&op=finished" class="btn btn-primary">Continue to log in to Koha</a></p> > [% ELSE %] >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38750
:
175699
|
175792