Bugzilla – Attachment 175701 Details for
Bug 38751
Creating ILL request through OPAC openURL explodes if same attribute defined twice
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38751: Update Standard ILL backend add_request
Bug-38751-Update-Standard-ILL-backend-addrequest.patch (text/plain), 1.50 KB, created by
Pedro Amorim
on 2024-12-19 12:04:12 UTC
(
hide
)
Description:
Bug 38751: Update Standard ILL backend add_request
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2024-12-19 12:04:12 UTC
Size:
1.50 KB
patch
obsolete
>From 2dc38c9827f1a289f5e501f979074b6dc07487a4 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Thu, 19 Dec 2024 11:57:07 +0000 >Subject: [PATCH] Bug 38751: Update Standard ILL backend add_request > >Make use of newly updated ILL::Request->extended_attributes method instead of creating the query manually >--- > Koha/ILL/Backend/Standard.pm | 18 ++++++------------ > 1 file changed, 6 insertions(+), 12 deletions(-) > >diff --git a/Koha/ILL/Backend/Standard.pm b/Koha/ILL/Backend/Standard.pm >index 41fc046bfff..d3ed496f7f4 100644 >--- a/Koha/ILL/Backend/Standard.pm >+++ b/Koha/ILL/Backend/Standard.pm >@@ -991,19 +991,13 @@ sub add_request { > if column_exists( 'illrequests', 'batch_id' ); > $request->store; > >- while ( my ( $type, $value ) = each %{$request_details} ) { >- if ( $value && length $value > 0 ) { >- Koha::ILL::Request::Attribute->new( >- { >- illrequest_id => $request->illrequest_id, >- column_exists( 'illrequestattributes', 'backend' ) ? ( backend => "Standard" ) : (), >- type => $type, >- value => $value, >- readonly => 0 >- } >- )->store; >+ my @request_details_array = map { >+ { >+ 'type' => $_, >+ 'value' => $request_details->{$_}, > } >- } >+ } keys %{$request_details}; >+ $request->extended_attributes( \@request_details_array ); > > return $request; > } >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38751
:
175700
|
175701
|
175702
|
175703
|
175704
|
175705
|
175903
|
175904
|
175905
|
176124
|
176250
|
176251
|
176252
|
176253