Bugzilla – Attachment 175775 Details for
Bug 36285
Staff UI form fieldset styling needs update
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36285: (QA follow-up): Use 30% as min-width, but if input has 'size' property, utilize that instead
Bug-36285-QA-follow-up-Use-30-as-min-width-but-if-.patch (text/plain), 1.45 KB, created by
Pedro Amorim
on 2024-12-19 15:27:52 UTC
(
hide
)
Description:
Bug 36285: (QA follow-up): Use 30% as min-width, but if input has 'size' property, utilize that instead
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2024-12-19 15:27:52 UTC
Size:
1.45 KB
patch
obsolete
>From d7695eb740fe5f714b9bce61897deb5c343114ec Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Thu, 19 Dec 2024 15:24:15 +0000 >Subject: [PATCH] Bug 36285: (QA follow-up): Use 30% as min-width, but if input > has 'size' property, utilize that instead > >Addresing Katrin's comment: >* Input field lengths appear longer in general - I quite like that in general. But wondering about fields with a set max-length like the copyright year in this form. It's still not the same length as the other input fields with the patch applied, but also not 'year-sized' anymore. Similar for zipcode in administration/libraries. >--- > koha-tmpl/intranet-tmpl/prog/css/src/_forms.scss | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/_forms.scss b/koha-tmpl/intranet-tmpl/prog/css/src/_forms.scss >index 48569a29574..fb649bef661 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/_forms.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/_forms.scss >@@ -129,10 +129,13 @@ fieldset { > border-color: rgba(60, 60, 60, 0.26); > border-width: 1px; > border-radius: 4px; >- min-width: 30%; >+ min-width: var(--size, 30%); > line-height: 1.5; > } > } >+ input[size] { >+ --size: attr(size, em); >+ } > > .v-select, > select { >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36285
:
162969
|
175772
|
175773
|
175774
| 175775 |
175776