Bugzilla – Attachment 175926 Details for
Bug 38782
ERM eUsage related tests are failing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38782: Remove concat in background process
Bug-38782-Remove-concat-in-background-process.patch (text/plain), 1.46 KB, created by
Tomás Cohen Arazi (tcohen)
on 2024-12-24 10:55:36 UTC
(
hide
)
Description:
Bug 38782: Remove concat in background process
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2024-12-24 10:55:36 UTC
Size:
1.46 KB
patch
obsolete
>From 287b468a09f9d8869737bf1577840abd47e80754 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Tue, 24 Dec 2024 10:42:21 +0000 >Subject: [PATCH] Bug 38782: Remove concat in background process > >The ud_provider->{report_type} is only defined on ->harvest_sushi, meaning it'll never be defined here. >We don't need this anyway. The filename should be the filename of the file being manually uploaded. We only need this concat logic for COUNTER files being generated by Koha following a SUSHI harvest, and that works. >This also gets rid of a warning when running the tests > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/BackgroundJob/ErmSushiHarvester.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/BackgroundJob/ErmSushiHarvester.pm b/Koha/BackgroundJob/ErmSushiHarvester.pm >index 5dadc0b60fd..da4721952bb 100644 >--- a/Koha/BackgroundJob/ErmSushiHarvester.pm >+++ b/Koha/BackgroundJob/ErmSushiHarvester.pm >@@ -92,7 +92,7 @@ sub process { > usage_data_provider_id => $ud_provider->erm_usage_data_provider_id, > file_content => $args->{file_content}, > date_uploaded => POSIX::strftime( "%Y%m%d%H%M%S", localtime ), >- filename => $ud_provider->name . "_" . $ud_provider->{report_type}, >+ filename => $ud_provider->name, > } > ] > ); >-- >2.47.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38782
:
175922
|
175923
|
175924
|
175925
| 175926 |
175927
|
175928
|
175929
|
175930