Bugzilla – Attachment 175928 Details for
Bug 38782
ERM eUsage related tests are failing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38782: Fix erm_custom_reports.t
Bug-38782-Fix-ermcustomreportst.patch (text/plain), 3.30 KB, created by
Pedro Amorim
on 2024-12-24 10:58:33 UTC
(
hide
)
Description:
Bug 38782: Fix erm_custom_reports.t
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2024-12-24 10:58:33 UTC
Size:
3.30 KB
patch
obsolete
>From 4ed65909f4b02b5ebfe5bcca9e04f834e8bd1e0e Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Tue, 24 Dec 2024 10:58:54 +0000 >Subject: [PATCH] Bug 38782: Fix erm_custom_reports.t > >DRY superlibrarian declarion to top for all test methods. >Apply same fix from before i.e. mock_userenv > >prove t/db_dependent/api/v1/erm_custom_reports.t >--- > t/db_dependent/api/v1/erm_custom_reports.t | 51 +++++----------------- > 1 file changed, 11 insertions(+), 40 deletions(-) > >diff --git a/t/db_dependent/api/v1/erm_custom_reports.t b/t/db_dependent/api/v1/erm_custom_reports.t >index 1317c61761e..274044ea9a7 100755 >--- a/t/db_dependent/api/v1/erm_custom_reports.t >+++ b/t/db_dependent/api/v1/erm_custom_reports.t >@@ -45,6 +45,17 @@ my $sushi_counter_5_response_TR_J1 = decode_json( read_file($sushi_response_file > my $report_items = $sushi_counter_5_response_TR_J1->{Report_Items}; > my $sushi_counter_TR_J1 = Koha::ERM::EUsage::SushiCounter->new( { response => $sushi_counter_5_response_TR_J1 } ); > >+my $librarian = $builder->build_object( >+ { >+ class => 'Koha::Patrons', >+ value => { flags => 2**28 } >+ } >+); >+my $password = 'thePassword123'; >+$librarian->set_password( { password => $password, skip_validation => 1 } ); >+my $userid = $librarian->userid; >+t::lib::Mocks::mock_userenv( { number => $userid } ); >+ > subtest "monthly_report" => sub { > plan tests => 17; > >@@ -64,16 +75,6 @@ subtest "monthly_report" => sub { > ] > ); > >- my $librarian = $builder->build_object( >- { >- class => 'Koha::Patrons', >- value => { flags => 2**28 } >- } >- ); >- my $password = 'thePassword123'; >- $librarian->set_password( { password => $password, skip_validation => 1 } ); >- my $userid = $librarian->userid; >- > my $patron = $builder->build_object( > { > class => 'Koha::Patrons', >@@ -162,16 +163,6 @@ subtest "yearly_report" => sub { > ] > ); > >- my $librarian = $builder->build_object( >- { >- class => 'Koha::Patrons', >- value => { flags => 2**28 } >- } >- ); >- my $password = 'thePassword123'; >- $librarian->set_password( { password => $password, skip_validation => 1 } ); >- my $userid = $librarian->userid; >- > my $patron = $builder->build_object( > { > class => 'Koha::Patrons', >@@ -251,16 +242,6 @@ subtest "metric_types_report" => sub { > ] > ); > >- my $librarian = $builder->build_object( >- { >- class => 'Koha::Patrons', >- value => { flags => 2**28 } >- } >- ); >- my $password = 'thePassword123'; >- $librarian->set_password( { password => $password, skip_validation => 1 } ); >- my $userid = $librarian->userid; >- > my $patron = $builder->build_object( > { > class => 'Koha::Patrons', >@@ -346,16 +327,6 @@ subtest "provider_rollup_report" => sub { > ] > ); > >- my $librarian = $builder->build_object( >- { >- class => 'Koha::Patrons', >- value => { flags => 2**28 } >- } >- ); >- my $password = 'thePassword123'; >- $librarian->set_password( { password => $password, skip_validation => 1 } ); >- my $userid = $librarian->userid; >- > my $patron = $builder->build_object( > { > class => 'Koha::Patrons', >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38782
:
175922
|
175923
|
175924
|
175925
|
175926
|
175927
|
175928
|
175929
|
175930