Bugzilla – Attachment 175932 Details for
Bug 38761
Backend plugins that are disabled remain visible
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38761: Don't pass the 'all' param when getting plugins
Bug-38761-Dont-pass-the-all-param-when-getting-plu.patch (text/plain), 1.66 KB, created by
David Nind
on 2024-12-24 12:55:11 UTC
(
hide
)
Description:
Bug 38761: Don't pass the 'all' param when getting plugins
Filename:
MIME Type:
Creator:
David Nind
Created:
2024-12-24 12:55:11 UTC
Size:
1.66 KB
patch
obsolete
>From f6bf71ef01cdbe63031d46fbbd8e9f81b2058594 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Fri, 20 Dec 2024 12:05:20 +0000 >Subject: [PATCH] Bug 38761: Don't pass the 'all' param when getting plugins > >Test plan: >1) Apply tests patch. Run. Notice it fails >2) Apply this patch. Run tests patch. Notice if passes. > >UI: >1) Enable ILLModule and install a backend plugin e.g.: >https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.5 >2) Create an ILL request: >http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl >3) Notice when you click 'New ILL request', 'PluginBackend' is listed even if the plugin is disabled. This patch fixes that. > >If there are existing requests and then their respective backend is disabled, no error occurs as plugins are loaded in the background even if disabled > >Signed-off-by: David Nind <david@davidnind.com> >--- > Koha/ILL/Request/Config.pm | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >diff --git a/Koha/ILL/Request/Config.pm b/Koha/ILL/Request/Config.pm >index 687c343cc6..0c73d42371 100644 >--- a/Koha/ILL/Request/Config.pm >+++ b/Koha/ILL/Request/Config.pm >@@ -108,7 +108,7 @@ sub backend_dir { > > my @backend_names = $config->get_backend_plugin_names(); > >-Returns a list of names for all the installed ILL backend plugins. >+Returns a list of names for all the installed (and enabled) ILL backend plugins. > > =cut > >@@ -119,8 +119,7 @@ sub get_backend_plugin_names { > my @backend_plugins = $koha_plugins > ? $koha_plugins->GetPlugins( > { >- method => 'ill_backend', >- all => 1 >+ method => 'ill_backend' > } > ) > : (); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38761
:
175824
|
175825
|
175826
|
175827
|
175931
|
175932
|
176271
|
176272