Bugzilla – Attachment 175952 Details for
Bug 36025
Extended attributes clause added to patron search query even when there are no searchable attributes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36025: Selenium test for the query parameters
Bug-36025-Selenium-test-for-the-query-parameters.patch (text/plain), 2.15 KB, created by
Andreas Jonsson
on 2024-12-27 10:08:09 UTC
(
hide
)
Description:
Bug 36025: Selenium test for the query parameters
Filename:
MIME Type:
Creator:
Andreas Jonsson
Created:
2024-12-27 10:08:09 UTC
Size:
2.15 KB
patch
obsolete
>From 2cfa370b5bdb14869f690d116ef4d493adeb2322 Mon Sep 17 00:00:00 2001 >From: Andreas Jonsson <andreas.jonsson@kreablo.se> >Date: Fri, 27 Dec 2024 10:01:50 +0000 >Subject: [PATCH] Bug 36025: Selenium test for the query parameters > >Fix selenium test: > >1. Use classname of form instead of no longer existing id >2. Fix test count >--- > t/db_dependent/selenium/patrons_search.t | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/selenium/patrons_search.t b/t/db_dependent/selenium/patrons_search.t >index 8aa1673fa9..af1c0b05de 100755 >--- a/t/db_dependent/selenium/patrons_search.t >+++ b/t/db_dependent/selenium/patrons_search.t >@@ -568,7 +568,7 @@ subtest 'Search patrons' => sub { > }; > > subtest 'Search patrons in modal' => sub { >- plan tests => 2; >+ plan tests => 3; > > setup(); > >@@ -836,6 +836,8 @@ subtest 'Search patrons in modal' => sub { > }; > > subtest 'no clause for extended_attributes when none are default searchable' => sub { >+ plan tests => 2; >+ > $attribute_type_searchable_1->update( { searched_by_default => 0 } ); > $attribute_type_searchable_2->update( { searched_by_default => 0 } ); > >@@ -843,7 +845,7 @@ subtest 'Search patrons in modal' => sub { > > $driver->execute_script( <<'EOF', 'capture_ajax_data' ); > jQuery( document ).on( "ajaxSend", function( event, request, settings ) { >- jQuery('#patron_search_form').after('<div id="capture_ajax_data_was_executed"></div>'); >+ jQuery('.patron_search_form').after('<div id="capture_ajax_data_was_executed"></div>'); > var url = new URL(window.location.origin + settings.url); > var parts = url.search.substring(1).split('&'); > var q; >@@ -860,7 +862,7 @@ jQuery( document ).on( "ajaxSend", function( event, request, settings ) { > for (var j = 0; q0 && j < q0.length; j++) { > for (var k = 0; k < q0[j].length; k++) { > if (q0[j][k].hasOwnProperty('extended_attributes.code')) { >- jQuery('#patron_search_form').after('<div id="had_extended_attributes_clause"></div>'); >+ jQuery('.patron_search_form').after('<div id="had_extended_attributes_clause"></div>'); > } > } > } >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36025
:
161873
|
161874
|
161914
|
161915
|
175917
|
175918
|
175952
|
176747
|
176748
|
176823
|
176824
|
178037
|
178038
|
178039
|
178081
|
178082
|
178083