Bugzilla – Attachment 175955 Details for
Bug 38302
Inconsistent delete confirmation dialog for "Delete list" buttons
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38302: Add delete confirmation dialog
Bug-38302-Add-delete-confirmation-dialog.patch (text/plain), 2.09 KB, created by
Katrin Fischer
on 2024-12-27 14:12:11 UTC
(
hide
)
Description:
Bug 38302: Add delete confirmation dialog
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2024-12-27 14:12:11 UTC
Size:
2.09 KB
patch
obsolete
>From 3d84e6ee4cade639f3c77554fde9ef3fbece3967 Mon Sep 17 00:00:00 2001 >From: Yanjun Li <yanjun.li@bywatersolutions.com> >Date: Mon, 4 Nov 2024 22:21:48 +0000 >Subject: [PATCH] Bug 38302: Add delete confirmation dialog > >To test: > >1. Create a list in the staff interface >2. Go to lists >3. See "Your lists" tab and find "Delete" button in "Actions" col, click "delete", no confirmation dialog pop up >4. Create another list >5. Go to lists and view the list detail >6. See "Edit" dropdown and click "Delete Lists" button, see confirmation dialog pop up >7. Apply patch >8. Try step 1 through 3 again >9. "Delete" button in "actions" column has the same confirmation dialog, and delete function works > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> >--- > .../prog/en/modules/virtualshelves/tables/shelves_results.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt >index abc6272c1d3..f47f7c6273f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt >@@ -54,7 +54,7 @@ > [%~ action_block = action_block _ '<input type="hidden" name="shelfnumber" value="' _ shelfnumber _ '" />' ~%] > [%~ action_block = action_block _ '<input type="hidden" name="public" value="' _ public _ '" />' ~%] > [%~ action_block = action_block _ '<input type="hidden" name="referer" value="list" />' ~%] >- [%~ action_block = action_block _ '<button type="submit" class="delete-list btn btn-default btn-xs"><i class="fa fa-trash-can"></i> ' _ t("Delete") _ '</button>' ~%] >+ [%~ action_block = action_block _ '<button type="submit" class="deleteshelf btn btn-default btn-xs"><i class="fa fa-trash-can"></i> ' _ t("Delete") _ '</button>' ~%] > [%~ action_block = action_block _ '</form>' ~%] > [%~ END ~%] > [%~ IF public AND allow_transfer ~%] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38302
:
173953
|
174052
|
174639
|
174640
|
174719
|
174720
|
175951
|
175955
|
175956