Bugzilla – Attachment 176010 Details for
Bug 37334
Cannot filter holdings table by status
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37334: Add filter_by_has_holds tests
Bug-37334-Add-filterbyhasholds-tests.patch (text/plain), 2.27 KB, created by
Lucas Gass (lukeg)
on 2024-12-30 15:32:13 UTC
(
hide
)
Description:
Bug 37334: Add filter_by_has_holds tests
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2024-12-30 15:32:13 UTC
Size:
2.27 KB
patch
obsolete
>From 90eff46d293062da0794f4bcd025db551d3a2335 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Thu, 21 Nov 2024 21:27:49 +0000 >Subject: [PATCH] Bug 37334: Add filter_by_has_holds tests > >--- > t/db_dependent/Koha/Items.t | 46 ++++++++++++++++++++++++++++++++++++- > 1 file changed, 45 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/Items.t b/t/db_dependent/Koha/Items.t >index 8f6520b31c..aa3e0d4a0a 100755 >--- a/t/db_dependent/Koha/Items.t >+++ b/t/db_dependent/Koha/Items.t >@@ -19,7 +19,7 @@ > > use Modern::Perl; > >-use Test::More tests => 22; >+use Test::More tests => 23; > > use Test::MockModule; > use Test::Exception; >@@ -34,6 +34,7 @@ use Koha::Items; > use Koha::Database; > use Koha::DateUtils qw( dt_from_string ); > use Koha::Statistics; >+use Koha::Recalls; > > use t::lib::TestBuilder; > use t::lib::Mocks; >@@ -2301,3 +2302,46 @@ subtest 'filter_by_in_transit' => sub { > $schema->storage->txn_rollback; > > }; >+ >+subtest 'filter_by_has_holds' => sub { >+ plan tests => 3; >+ >+ $schema->storage->txn_begin; >+ >+ my $patron = $builder->build_object( { class => 'Koha::Patrons' } ); >+ t::lib::Mocks::mock_userenv( { branchcode => $patron->branchcode } ); >+ >+ my $library_1 = $builder->build( { source => 'Branch' } ); >+ my $library_2 = $builder->build( { source => 'Branch' } ); >+ >+ my $biblio = $builder->build_sample_biblio(); >+ my $item_1 = $builder->build_sample_item({ biblionumber => $biblio->biblionumber, }); >+ my $item_2 = $builder->build_sample_item({ biblionumber => $biblio->biblionumber, }); >+ >+ is ( $biblio->items->filter_by_has_holds->count, 0, "Filtered to 0 holds" ); >+ >+ my $hold_1 = $builder->build( >+ { >+ source => 'Reserve', >+ value => { >+ itemnumber => $item_1->itemnumber, reservedate => dt_from_string, >+ } >+ } >+ ); >+ >+ is ( $biblio->items->filter_by_has_holds->count, 1, "Filtered to 1 hold" ); >+ >+ my $hold_2 = $builder->build( >+ { >+ source => 'Reserve', >+ value => { >+ itemnumber => $item_2->itemnumber, reservedate => dt_from_string, >+ } >+ } >+ ); >+ >+ is ( $biblio->items->filter_by_has_holds->count, 2, "Filtered to 2 holds" ); >+ >+ $schema->storage->txn_rollback; >+ >+}; >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37334
:
172300
|
172301
|
172302
|
173499
|
173500
|
173501
|
173949
|
173950
|
173951
|
173982
|
174310
|
174798
|
174799
|
174800
|
174801
|
174802
|
174803
|
174804
|
174813
|
174814
|
174901
|
174902
|
174903
|
174955
|
175859
|
175860
|
175861
|
175862
|
175863
|
175864
|
175865
|
175866
|
175867
|
175868
|
175869
|
175870
|
175871
|
175999
|
176000
|
176001
|
176002
|
176003
|
176004
|
176005
|
176006
|
176007
|
176008
|
176009
|
176010
|
176011
|
176023
|
176024
|
176025
|
176026
|
176027
|
176028
|
176029
|
176030
|
176031
|
176032
|
176033
|
176034
|
176035
|
176475
|
176477
|
176480
|
176481
|
177321
|
177415
|
177416
|
177417
|
177418
|
177419
|
177420
|
177421
|
177422
|
177423
|
177424
|
177425
|
177426
|
177427
|
177428
|
177429
|
177430
|
177431
|
177432