Bugzilla – Attachment 176104 Details for
Bug 36585
Report 'Patrons with the most checkouts' doesn't have the total when outputting to CSV
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36585: (QA follow-up) Fix tab spaces
Bug-36585-QA-follow-up-Fix-tab-spaces.patch (text/plain), 3.40 KB, created by
Lisette Scheer
on 2025-01-02 19:06:28 UTC
(
hide
)
Description:
Bug 36585: (QA follow-up) Fix tab spaces
Filename:
MIME Type:
Creator:
Lisette Scheer
Created:
2025-01-02 19:06:28 UTC
Size:
3.40 KB
patch
obsolete
>From 86655e4255de1517c1dc74c291367d94d7b2fb79 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Thu, 2 Jan 2025 18:43:30 +0000 >Subject: [PATCH] Bug 36585: (QA follow-up) Fix tab spaces > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> >--- > .../prog/en/modules/reports/bor_issues_top.tt | 22 +++++++++---------- > reports/bor_issues_top.pl | 6 ++--- > 2 files changed, 14 insertions(+), 14 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/bor_issues_top.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/bor_issues_top.tt >index 702b93c096f..97b933b7915 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/bor_issues_top.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/bor_issues_top.tt >@@ -86,12 +86,12 @@ > > <table> > <tr> >- <th rowspan="2">Rank</th> >- <th rowspan="2">Patron</th> >- <th rowspan="2">Total</th> >- [% FOREACH loopco IN mainloo.loopcol %] >- <th>[% loopco.coltitle | html %]</th> >- [% END %] >+ <th rowspan="2">Rank</th> >+ <th rowspan="2">Patron</th> >+ <th rowspan="2">Total</th> >+ [% FOREACH loopco IN mainloo.loopcol %] >+ <th>[% loopco.coltitle | html %]</th> >+ [% END %] > </tr> > <tr> > [% FOREACH loopco IN mainloo.loopcol %] >@@ -102,11 +102,11 @@ > <tr> > [% IF ( loopro.hilighted ) %]<td>[% ELSE %]<td>[% END %] > [% loopro.rowtitle | html %]</td> >- [% IF ( loopro.hilighted ) %]<td>[% ELSE %]<td>[% END %] >- [% IF ( loopro.reference ) %]<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% loopro.reference | uri %]">[% END %] >- [% IF ( loopro.patron ) %][% loopro.patron | html %][% END %] >- [% IF ( loopro.reference ) %]</a>[% END %] >- </td> >+ [% IF ( loopro.hilighted ) %]<td>[% ELSE %]<td>[% END %] >+ [% IF ( loopro.reference ) %]<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% loopro.reference | uri %]">[% END %] >+ [% IF ( loopro.patron ) %][% loopro.patron | html %][% END %] >+ [% IF ( loopro.reference ) %]</a>[% END %] >+ </td> > [% FOREACH loopcel IN loopro.loopcell %] > [% IF ( loopcel.hilighted ) %]<td>[% ELSE %]<td>[% END %] > [% IF ( loopcel.count ) %][% loopcel.count | html %][% END %] >diff --git a/reports/bor_issues_top.pl b/reports/bor_issues_top.pl >index 617b3c97034..d4bf082813c 100755 >--- a/reports/bor_issues_top.pl >+++ b/reports/bor_issues_top.pl >@@ -80,13 +80,13 @@ if ($do_it) { > my $x = $line->{loopcell}; > print $line->{rowtitle}.$sep; > print '"'.$line->{patron}.'"'.$sep; >- print join($sep, map {$_->{count}} @$x); >+ print join($sep, map {$_->{count}} @$x); > print "\n"; > } > # footer > print "TOTAL"; > $cols = @$results[0]->{loopfooter}; >- print join($sep, map {$_->{total}} @$cols); >+ print join($sep, map {$_->{total}} @$cols); > print $sep.@$results[0]->{total}; > } > exit; >@@ -247,7 +247,7 @@ sub calculate { > 'old_issues.returndate >', > 'old_issues.returndate <', > 'old_issues.branchcode like', >- 'items.itype like', >+ 'items.itype like', > 'borrowers.categorycode like', > ); > foreach ((@$filters)[0..9]) { >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36585
:
164782
|
167248
|
167251
|
176100
|
176102
|
176103
| 176104