Bugzilla – Attachment 176106 Details for
Bug 38813
Curbside pickups tab not selected in OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[24.05.x] Bug 38813: Make inner tabs selected correctly
2405x-Bug-38813-Make-inner-tabs-selected-correctly.patch (text/plain), 2.71 KB, created by
Tomás Cohen Arazi (tcohen)
on 2025-01-02 19:11:42 UTC
(
hide
)
Description:
[24.05.x] Bug 38813: Make inner tabs selected correctly
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2025-01-02 19:11:42 UTC
Size:
2.71 KB
patch
obsolete
>From a84c4c5a259311b0086cf44d1e1f4056300c691e Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Thu, 2 Jan 2025 16:02:57 -0300 >Subject: [PATCH] [24.05.x] Bug 38813: Make inner tabs selected correctly > >On the 24.05.x branch (i.e. before the tab wrapper) the template logic >is making it not select the first tab if there are no policies defined. > >To test: >1. Have KTD running on 24.05.x >2. Enable the `CurbsidePickups` system preference >3. Define a policy (anyone), DISABLED >4. Log into the OPAC and point your browser to <koha>/cgi-bin/koha/opac-curbside-pickups.pl >=> FAIL: The 'Your pickups' tab is grey (not selected) and there's no >content below it >5. ENABLE the policy and reload the OPAC >=> SUCCESS: Notice it gives you the option to 'Schedule a pickup', >selected by default. >6. Apply this patch >7. Repeat 5 >=> SUCCESS: No behavior change >8. Repeat 3-4 >=> SUCCESS: The 'Your pickups' tab is selected, and the 'No curbside >pickups' message displayed >9. Sign off :-D >--- > .../opac-tmpl/bootstrap/en/modules/opac-curbside-pickups.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-curbside-pickups.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-curbside-pickups.tt >index 03c7bc7999b..1e5d4ff418f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-curbside-pickups.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-curbside-pickups.tt >@@ -141,7 +141,7 @@ > <div id="opac-pickups-views" class="toptabs"> > <ul class="nav nav-tabs" role="tablist"> > <li class="nav-item" role="presentation" id="tab-user-pickups"> >- [% IF patron_curbside_pickups.count %] >+ [% IF patron_curbside_pickups.count || !policies.count %] > <a href="#user-pickups" class="nav-link active" aria-controls="user-pickups" aria-selected="true" role="tab" data-toggle="tab">Your pickups</a> > [% ELSE %] > <a href="#user-pickups" class="nav-link" aria-controls="user-pickups" role="tab" data-toggle="tab">Your pickups</a> >@@ -160,7 +160,7 @@ > </ul> > > <div class="tab-content"> >- [% IF patron_curbside_pickups.count %] >+ [% IF patron_curbside_pickups.count || !policies.count %] > <div role="tabpanel" class="tab-pane active" id="user-pickups" aria-labelledby="tab-user-pickups"> > [% ELSE %] > <div role="tabpanel" class="tab-pane" id="user-pickups" aria-labelledby="tab-user-pickups"> >-- >2.47.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38813
:
176098
|
176101
| 176106 |
176836