Bugzilla – Attachment 176151 Details for
Bug 38832
Dead code in catalogue/search.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38832: Remove code related to outer_servers_loop and outer_sup_servers_loop
Bug-38832-Remove-code-related-to-outerserversloop-.patch (text/plain), 4.47 KB, created by
Jonathan Druart
on 2025-01-06 15:06:39 UTC
(
hide
)
Description:
Bug 38832: Remove code related to outer_servers_loop and outer_sup_servers_loop
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-01-06 15:06:39 UTC
Size:
4.47 KB
patch
obsolete
>From d3c9ab99efc0d4e9adfc1aa0ad6d7579a69cb6aa Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 6 Jan 2025 15:56:27 +0100 >Subject: [PATCH] Bug 38832: Remove code related to outer_servers_loop and > outer_sup_servers_loop > >This is clearly dead code as it's never set in the controller file. >--- > catalogue/search.pl | 7 ---- > .../prog/en/modules/catalogue/advsearch.tt | 36 ------------------- > 2 files changed, 43 deletions(-) > >diff --git a/catalogue/search.pl b/catalogue/search.pl >index ba97a75f1c0..14e6279f61e 100755 >--- a/catalogue/search.pl >+++ b/catalogue/search.pl >@@ -315,13 +315,6 @@ if ( $template_type eq 'advsearch' ) { > > $expanded = 1 if scalar @operators || scalar @limits; > >- # load the servers (used for searching -- to do federated searching, etc.) >- my $primary_servers_loop;# = displayPrimaryServers(); >- $template->param(outer_servers_loop => $primary_servers_loop,); >- >- my $secondary_servers_loop; >- $template->param(outer_sup_servers_loop => $secondary_servers_loop,); >- > # set the default sorting > if ($default_sort_by) { > $template->param( sort_by => $default_sort_by ); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt >index 9e5562ae648..894ef1116a6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt >@@ -109,42 +109,6 @@ > <!-- /SEARCH BUTTONS --> > [% END %] > >- [% IF ( outer_servers_loop ) %] >- <!-- DATABASES --> >- <fieldset> >- <legend>Select local databases</legend> >- [% FOREACH local_servers_loo IN local_servers_loop %] >- [% IF ( local_servers_loo.checked ) %] >- <input type="checkbox" id="[% local_servers_loo.id | html %]" name="[% local_servers_loo.name | html %]" checked="checked" value="[% local_servers_loo.value | html %]" /> >- [% ELSE %] >- <input type="checkbox" id="[% local_servers_loo.id | html %]" name="[% local_servers_loo.name | html %]" value="[% local_servers_loo.value | html %]" /> >- [% END %] >- <label for="[% local_servers_loo.id | html %]"> >- <img width="16" height="16" alt="[% local_servers_loo.id | html %]" src="[% themelang | html %]/img/[% local_servers_loo.icon | html %]" /> [% local_servers_loo.label | html %] >- </label> >- [% END # /FOREACH local_servers_loo %] >- </fieldset> >- <!-- /DATABASES --> >- [% END # /IF ( outer_servers_loop ) %] >- >- [% IF ( outer_servers_loop ) %] >- <!-- REMOTE DATABASES --> >- <fieldset id="databases"> >- <legend>Select remote databases</legend> >- [% FOREACH outer_servers_loo IN outer_servers_loop %] >- [% IF ( outer_servers_loo.checked ) %] >- <input type="checkbox" id="[% outer_servers_loo.id | html %]" name="[% outer_servers_loo.name | html %]" checked="checked" value="[% outer_servers_loo.value | html %]" /> >- [% ELSE %] >- <input type="checkbox" id="[% outer_servers_loo.id | html %]" name="[% outer_servers_loo.name | html %]" value="[% outer_servers_loo.value | html %]" /> >- [% END %] >- <label for="[% outer_servers_loo.id | html %]"> >- <img alt="[% outer_servers_loo.id | html %]" src="[% themelang | html %]/images/[% outer_servers_loo.icon | html %]" />[% outer_servers_loo.label | html %] >- </label> >- [% END # /FOREACH outer_servers_loo %] >- </fieldset> <!-- /#databases --> >- <!-- /REMOTE DATABASES --> >- [% END %] >- > <!-- BOOLEAN SEARCH OPTIONS --> > <fieldset id="searchterms"> > <legend>Search for </legend> >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38832
:
176151
|
176152
|
176167
|
176168
|
176169
|
176336
|
176337
|
176338