Bugzilla – Attachment 176199 Details for
Bug 38147
Edit button in bookings untranslatable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38147: Fix Edit and Cancel translatability in booking table
Bug-38147-Fix-Edit-and-Cancel-translatability-in-b.patch (text/plain), 3.77 KB, created by
Martin Renvoize (ashimema)
on 2025-01-07 15:46:15 UTC
(
hide
)
Description:
Bug 38147: Fix Edit and Cancel translatability in booking table
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-01-07 15:46:15 UTC
Size:
3.77 KB
patch
obsolete
>From 64b69788ed2a33f8bdc4d3254dbe549c3f2d1bb3 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 15 Oct 2024 14:17:16 +0200 >Subject: [PATCH] Bug 38147: Fix Edit and Cancel translatability in booking > table > >It seems that "Edit" was not picked by the translator script because there was a TT tag >on the same line. > >See comment 0 for a test plan. > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../intranet-tmpl/prog/en/modules/bookings/list.tt | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt >index 5c267222dd2..6a1061403ff 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt >@@ -91,15 +91,16 @@ > var update_success = 0; > var bookings_table; > var timeline; >+ let biblionumber = "[% biblionumber | uri %]"; > $(document).ready(function(){ > > var items = $.ajax({ >- url: '/api/v1/biblios/[% biblionumber | uri %]/items?bookable=1', >+ url: '/api/v1/biblios/%s/items?bookable=1'.format(biblionumber), > dataType: 'json', > type: 'GET' > }); > var bookings = $.ajax({ >- url: '/api/v1/biblios/[% biblionumber | uri %]/bookings?_per_page=-1', >+ url: '/api/v1/biblios/%s/bookings?_per_page=-1'.format(biblionumber), > headers: { 'x-koha-embed': 'patron' }, > dataType: 'json', > type: 'GET', >@@ -247,7 +248,7 @@ > }, > }; > >- var bookings_table_url = "/api/v1/biblios/[% biblionumber | uri %]/bookings"; >+ var bookings_table_url = "/api/v1/biblios/%s/bookings".format(biblionumber); > bookings_table = $('#bookings_table').kohaTable({ > "ajax": { > "url": bookings_table_url >@@ -386,8 +387,8 @@ > let is_cancelled = row.status === "cancelled"; > [% IF CAN_user_circulate_manage_bookings %] > if (!is_cancelled) { >- result += '<button type="button" class="btn btn-default btn-xs edit-action" data-bs-toggle="modal" data-bs-target="#placeBookingModal" data-booking="'+row.booking_id+'" data-biblionumber="[% biblionumber | uri %]" data-itemnumber="'+row.item_id+'" data-patron="'+row.patron_id+'" data-pickup_library="'+row.pickup_library_id+'" data-start_date="'+row.start_date+'" data-end_date="'+row.end_date+'"><i class="fa fa-pencil" aria-hidden="true"></i> '+_("Edit")+'</button>'; >- result += '<button type="button" class="btn btn-default btn-xs cancel-action" data-bs-toggle="modal" data-bs-target="#cancelBookingModal" data-booking="'+row.booking_id+'"><i class="fa fa-trash" aria-hidden="true"></i> '+_("Cancel")+'</button>'; >+ result += '<button type="button" class="btn btn-default btn-xs edit-action" data-bs-toggle="modal" data-bs-target="#placeBookingModal" data-booking="%s" data-biblionumber="%s" data-itemnumber="%s" data-patron="%s" data-pickup_library="%s" data-start_date="%s" data-end_date="%s"><i class="fa fa-pencil" aria-hidden="true"></i> %s</button>'.format(row.booking_id, biblionumber, row.item_id, row.patron_id, row.pickup_library_id, row.start_date, row.end_date, _("Edit")); >+ result += '<button type="button" class="btn btn-default btn-xs cancel-action" data-bs-toggle="modal" data-bs-target="#cancelBookingModal" data-booking="%s"><i class="fa fa-trash" aria-hidden="true"></i> %s</button>'.format(row.booking_id, _("Cancel")); > } > [% END %] > return result; >-- >2.47.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38147
:
172769
|
173013
|
176044
|
176057
| 176199