Bugzilla – Attachment 176208 Details for
Bug 38646
C4::Languages::getLanguages is very unreasonably slow (100+ ms)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38646: (QA folllow-up) Fix ONLY_FULL_GROUP_BY
Bug-38646-QA-folllow-up-Fix-ONLYFULLGROUPBY.patch (text/plain), 1021 bytes, created by
Martin Renvoize (ashimema)
on 2025-01-07 16:47:11 UTC
(
hide
)
Description:
Bug 38646: (QA folllow-up) Fix ONLY_FULL_GROUP_BY
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-01-07 16:47:11 UTC
Size:
1021 bytes
patch
obsolete
>From edd866727216c6258b079adbde681d0ae098f3d6 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 7 Jan 2025 16:43:44 +0000 >Subject: [PATCH] Bug 38646: (QA folllow-up) Fix ONLY_FULL_GROUP_BY > >We can use a plain AND in the WHERE clause here rather than requireing a >HAVING. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/Languages.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Languages.pm b/C4/Languages.pm >index 28e8286c561..e84aa1418a3 100644 >--- a/C4/Languages.pm >+++ b/C4/Languages.pm >@@ -200,7 +200,7 @@ sub getLanguages { > } > > my $language_list = $isFiltered ? C4::Context->preference("AdvancedSearchLanguages") : undef; >- my $language_list_cond = $language_list ? 'HAVING FIND_IN_SET(language_rfc4646_to_iso639.iso639_2_code, ?)' : ''; >+ my $language_list_cond = $language_list ? 'AND FIND_IN_SET(language_rfc4646_to_iso639.iso639_2_code, ?)' : ''; > > my $sth = $dbh->prepare(" > SELECT >-- >2.47.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38646
:
175262
|
176207
|
176208
|
176227
|
176228
|
176229
|
176231
|
176232
|
176233
|
176234